From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
akpm <akpm@linux-foundation.org>,
torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pti: add missing CONFIG_PCI dependency
Date: Wed, 03 Aug 2011 09:04:15 -0700 [thread overview]
Message-ID: <4E39717F.6010804@linux.intel.com> (raw)
In-Reply-To: <CAMuHMdUNh8tYrVn60aHY2dZ1jZNbBrhe_+V5AVxBTZqnTvH__A@mail.gmail.com>
On 08/03/2011 12:20 AM, Geert Uytterhoeven wrote:
> On Tue, Aug 2, 2011 at 17:11, Randy Dunlap<rdunlap@xenotime.net> wrote:
>> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>>
>>> From: Heiko Carstens<heiko.carstens@de.ibm.com>
>>>
>>> allmodconfig compile fails on s390 because of the new PTI driver:
>>>
>>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>>
>>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>>
>>> Cc: J Freyensee<james_p_freyensee@linux.intel.com>
>>
>> James has already acked my identical patch.
>> The problem seems to be that we don't have a drivers/misc/ maintainter to
>> merge the patch.
>>
>> Anyway:
>> Acked-by: Randy Dunlap<rdunlap@xenotime.net>
>
> It's also missing
>
> #include<linux/slab.h>
> #include<linux/uaccess.h>
>
Yes, the other patch and url I sent to Greg yesterday will take care of
that.
Thanks
> Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4429212/
>
> drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc'
> drivers/misc/pti.c:657: error: implicit declaration of function 'copy_from_user'
> drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc'
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation
prev parent reply other threads:[~2011-08-03 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 8:08 [PATCH] pti: add missing CONFIG_PCI dependency Heiko Carstens
2011-08-02 15:11 ` Randy Dunlap
2011-08-02 16:17 ` J Freyensee
2011-08-02 16:24 ` Greg KH
2011-08-02 16:36 ` J Freyensee
2011-08-03 7:20 ` Geert Uytterhoeven
2011-08-03 16:04 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E39717F.6010804@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox