[PATCH] pti: add missing CONFIG_PCI dependency

[PATCH] pti: add missing CONFIG_PCI dependency

[Heiko Carstens]

From: Heiko Carstens <heiko.carstens@de.ibm.com>

allmodconfig compile fails on s390 because of the new PTI driver:

drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'

Add a 'depends on PCI' statement so it doesn't get compiled.

Cc: J Freyensee <james_p_freyensee@linux.intel.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 drivers/misc/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -146,6 +146,7 @@ config PHANTOM
 
 config INTEL_MID_PTI
 	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+	depends on PCI
 	default n
 	help
 	  The PTI (Parallel Trace Interface) driver directs

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[Randy Dunlap]

On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> allmodconfig compile fails on s390 because of the new PTI driver:
> 
> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
> 
> Add a 'depends on PCI' statement so it doesn't get compiled.
> 
> Cc: J Freyensee <james_p_freyensee@linux.intel.com>

James has already acked my identical patch.
The problem seems to be that we don't have a drivers/misc/ maintainter to
merge the patch.

Anyway:
Acked-by: Randy Dunlap <rdunlap@xenotime.net>


> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -146,6 +146,7 @@ config PHANTOM
>  
>  config INTEL_MID_PTI
>  	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> +	depends on PCI
>  	default n
>  	help
>  	  The PTI (Parallel Trace Interface) driver directs
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[J Freyensee]

On 08/02/2011 08:11 AM, Randy Dunlap wrote:
> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>
>> From: Heiko Carstens<heiko.carstens@de.ibm.com>
>>
>> allmodconfig compile fails on s390 because of the new PTI driver:
>>
>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>
>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>
>> Cc: J Freyensee<james_p_freyensee@linux.intel.com>
>

Greg, did you see the patch go your way?

http://marc.info/?l=linux-kernel&m=131007615706260&w=2

Should I res-submit this patch to you through the linux-next mailing list?

Thanks Greg,

J

> James has already acked my identical patch.
> The problem seems to be that we don't have a drivers/misc/ maintainter to
> merge the patch.
>
> Anyway:
> Acked-by: Randy Dunlap<rdunlap@xenotime.net>
>
>
>> Signed-off-by: Heiko Carstens<heiko.carstens@de.ibm.com>
>> ---
>>   drivers/misc/Kconfig |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> --- a/drivers/misc/Kconfig
>> +++ b/drivers/misc/Kconfig
>> @@ -146,6 +146,7 @@ config PHANTOM
>>
>>   config INTEL_MID_PTI
>>   	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
>> +	depends on PCI
>>   	default n
>>   	help
>>   	  The PTI (Parallel Trace Interface) driver directs
>> --
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


-- 
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[Greg KH]

On Tue, Aug 02, 2011 at 09:17:45AM -0700, J Freyensee wrote:
> On 08/02/2011 08:11 AM, Randy Dunlap wrote:
> >On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
> >
> >>From: Heiko Carstens<heiko.carstens@de.ibm.com>
> >>
> >>allmodconfig compile fails on s390 because of the new PTI driver:
> >>
> >>drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
> >>drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
> >>
> >>Add a 'depends on PCI' statement so it doesn't get compiled.
> >>
> >>Cc: J Freyensee<james_p_freyensee@linux.intel.com>
> >
> 
> Greg, did you see the patch go your way?
> 
> http://marc.info/?l=linux-kernel&m=131007615706260&w=2
> 
> Should I res-submit this patch to you through the linux-next mailing list?

I'll pick it up, it's in my "to-apply" queue now.

thanks,

greg k-h

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[J Freyensee]

On 08/02/2011 09:24 AM, Greg KH wrote:
> On Tue, Aug 02, 2011 at 09:17:45AM -0700, J Freyensee wrote:
>> On 08/02/2011 08:11 AM, Randy Dunlap wrote:
>>> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>>>
>>>> From: Heiko Carstens<heiko.carstens@de.ibm.com>
>>>>
>>>> allmodconfig compile fails on s390 because of the new PTI driver:
>>>>
>>>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>>>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>>>
>>>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>>>
>>>> Cc: J Freyensee<james_p_freyensee@linux.intel.com>
>>>
>>
>> Greg, did you see the patch go your way?
>>
>> http://marc.info/?l=linux-kernel&m=131007615706260&w=2
>>
>> Should I res-submit this patch to you through the linux-next mailing list?
>
> I'll pick it up, it's in my "to-apply" queue now.

Thanks Greg.

There probably is one more pti patch that has not been applied as well. 
  Stephen Rothwell asked about drivers/misc patches a week ago and I 
responded about this additional patch I also sent:

http://marc.info/?l=linux-next&m=131016084730837&w=2

I apologize for the confusion.


>
> thanks,
>
> greg k-h


-- 
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[Geert Uytterhoeven]

On Tue, Aug 2, 2011 at 17:11, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>
>> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>>
>> allmodconfig compile fails on s390 because of the new PTI driver:
>>
>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>
>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>
>> Cc: J Freyensee <james_p_freyensee@linux.intel.com>
>
> James has already acked my identical patch.
> The problem seems to be that we don't have a drivers/misc/ maintainter to
> merge the patch.
>
> Anyway:
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>

It's also missing

#include <linux/slab.h>
#include <linux/uaccess.h>

Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4429212/

drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc'
drivers/misc/pti.c:657: error: implicit declaration of function 'copy_from_user'
drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc'

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] pti: add missing CONFIG_PCI dependency

[J Freyensee]

On 08/03/2011 12:20 AM, Geert Uytterhoeven wrote:
> On Tue, Aug 2, 2011 at 17:11, Randy Dunlap<rdunlap@xenotime.net>  wrote:
>> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>>
>>> From: Heiko Carstens<heiko.carstens@de.ibm.com>
>>>
>>> allmodconfig compile fails on s390 because of the new PTI driver:
>>>
>>> drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
>>> drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
>>>
>>> Add a 'depends on PCI' statement so it doesn't get compiled.
>>>
>>> Cc: J Freyensee<james_p_freyensee@linux.intel.com>
>>
>> James has already acked my identical patch.
>> The problem seems to be that we don't have a drivers/misc/ maintainter to
>> merge the patch.
>>
>> Anyway:
>> Acked-by: Randy Dunlap<rdunlap@xenotime.net>
>
> It's also missing
>
> #include<linux/slab.h>
> #include<linux/uaccess.h>
>

Yes, the other patch and url I sent to Greg yesterday will take care of 
that.

Thanks


> Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4429212/
>
> drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc'
> drivers/misc/pti.c:657: error: implicit declaration of function 'copy_from_user'
> drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc'
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


-- 
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation