From: Joe Jin <joe.jin@oracle.com>
To: Daniel Stodden <daniel.stodden@citrix.com>,
Jens Axboe <jaxboe@fusionio.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Annie Li <annie.li@oracle.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Kurt C Hackel <KURT.HACKEL@oracle.com>
Cc: Greg Marsden <greg.marsden@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joe Jin <joe.jin@oracle.com>
Subject: [PATCH -v3 0/3] xen-blkback: refactor vbd remove/disconnect.
Date: Thu, 04 Aug 2011 15:21:17 +0800 [thread overview]
Message-ID: <4E3A486D.7060506@oracle.com> (raw)
This patchset is a backport and original patch author is Daniel Stodden:
http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch
Initial issue:
When we do block device attach/detach test with below steps, umount hang
in guest and the guest unable to shutdown:
1. start guest with the latest kernel.
2. attach new block device by xm block-attach in Dom0
3. mount new disk in guest
4. execute xm block-detach to detach the block device in dom0 until timeout
5. try to unmount the disk in guest, umount hung. at here, any IOs to the
device will hang.
Root cause:
This caused by 'xm block-detach' in Dom0 set backend device's state to
'XenbusStateClosing', frontend received the notification and
blkfront_closing() be called, at the moment, the disk still using by guest,
so frontend refused to close. In the blkfront_closing(), frontend send a
notification to backend said that the its state switched to 'Closing', when
backend got the event, it will disconnect from real device, at here any IO
request will be stuck, even tried to release the disk by umount.
So this may fix either frontend or backend, I have send a fix for frontend:
https://lkml.org/lkml/2011/7/8/159
Ian think we should fix it from backend and he pointed out Daniel Stodden have
submitted a patch(see above link) for xen-blkback, I tried it and it works
well.
Changes:
v3:
- Unregister the device when backend state switch to XenbusStateClosed.
v2:
- Reformat code style.
- Per Knoard suggestions, change some int defines to bool.
drivers/block/xen-blkback/blkback.c | 10 +--
drivers/block/xen-blkback/common.h | 5 +
drivers/block/xen-blkback/xenbus.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
3 files changed, 195 insertions(+), 26 deletions(-)
next reply other threads:[~2011-08-04 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 7:21 Joe Jin [this message]
2011-08-04 7:23 ` [PATCH -v3 1/3] xen-blkback: add remove_requested to xen_blkif and some declares Joe Jin
2011-08-06 14:39 ` Konrad Rzeszutek Wilk
2011-08-04 7:24 ` [PATCH -v3 2/3] xen-blkback: repleace check kthread_should_stop() to remove_requested in xen_blkif_schedule() loop Joe Jin
2011-08-04 19:48 ` Konrad Rzeszutek Wilk
2011-08-05 9:42 ` [Xen-devel] " David Vrabel
2011-08-04 7:25 ` [PATCH -v3 3/3] xen-blkback: refactor vbd remove/disconnect Joe Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3A486D.7060506@oracle.com \
--to=joe.jin@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=KURT.HACKEL@oracle.com \
--cc=annie.li@oracle.com \
--cc=daniel.stodden@citrix.com \
--cc=greg.marsden@oracle.com \
--cc=jaxboe@fusionio.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox