From: Jens Axboe <jaxboe@fusionio.com>
To: Tao Ma <tm@tao.ma>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Roland Dreier <roland@purestorage.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] block: Make rq_affinity = 1 work as expected.
Date: Fri, 5 Aug 2011 09:33:00 +0200 [thread overview]
Message-ID: <4E3B9CAC.7020802@fusionio.com> (raw)
In-Reply-To: <1312519150-3261-1-git-send-email-tm@tao.ma>
On 2011-08-05 06:39, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> Commit 5757a6d76c introduced a new rq_affinity = 2 so as to make
> the request completed in the __make_request cpu. But it makes the
> old rq_affinity = 1 not work any more. The root cause is that
> if the 'cpu' and 'req->cpu' is in the same group and cpu != req->cpu,
> ccpu will be the same as group_cpu, so the completion will be
> excuted in the 'cpu' not 'group_cpu'.
>
> This patch fix problem by simpling removing group_cpu and the codes
> are more explicit now. If ccpu == cpu, we complete in cpu, otherwise
> we raise_blk_irq to ccpu.
Thanks Tao Ma, much more readable too.
--
Jens Axboe
next prev parent reply other threads:[~2011-08-05 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 4:39 [PATCH] block: Make rq_affinity = 1 work as expected Tao Ma
2011-08-05 5:12 ` Shaohua Li
2011-08-05 21:26 ` Williams, Dan J
2011-08-05 7:33 ` Jens Axboe [this message]
2011-08-08 2:58 ` Shaohua Li
2011-08-08 3:46 ` Tao Ma
2011-08-08 4:33 ` Shaohua Li
2011-08-08 5:40 ` Tao Ma
2011-08-08 5:56 ` Shaohua Li
2011-08-08 6:31 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3B9CAC.7020802@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@purestorage.com \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox