From: David Vrabel <dvrabel@cantab.net>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Joe Jin <joe.jin@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jens Axboe <jaxboe@fusionio.com>,
Greg Marsden <greg.marsden@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Annie Li <annie.li@oracle.com>,
Kurt C Hackel <KURT.HACKEL@oracle.com>,
Daniel Stodden <daniel.stodden@citrix.com>
Subject: Re: [Xen-devel] Re: [PATCH -v3 2/3] xen-blkback: repleace check kthread_should_stop() to remove_requested in xen_blkif_schedule() loop.
Date: Fri, 05 Aug 2011 10:42:24 +0100 [thread overview]
Message-ID: <4E3BBB00.1050101@cantab.net> (raw)
In-Reply-To: <20110804194838.GA12459@dumpdata.com>
On 04/08/2011 20:48, Konrad Rzeszutek Wilk wrote:
> <sigh> I can't believe I didn't catch this earlier, but this a
> big NO NO. Each patch _MUST_ be compile on its own. If I commit
> patch 1 and this patch, the compile (actually linker) process
> stops b/c xen_blkback_close is not defined:
All three patches should be merged together as patch 2 on it's own will
break the driver as the thread will never exit as
blkif->remove_requested isn't set until patch 3.
David
next prev parent reply other threads:[~2011-08-05 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 7:21 [PATCH -v3 0/3] xen-blkback: refactor vbd remove/disconnect Joe Jin
2011-08-04 7:23 ` [PATCH -v3 1/3] xen-blkback: add remove_requested to xen_blkif and some declares Joe Jin
2011-08-06 14:39 ` Konrad Rzeszutek Wilk
2011-08-04 7:24 ` [PATCH -v3 2/3] xen-blkback: repleace check kthread_should_stop() to remove_requested in xen_blkif_schedule() loop Joe Jin
2011-08-04 19:48 ` Konrad Rzeszutek Wilk
2011-08-05 9:42 ` David Vrabel [this message]
2011-08-04 7:25 ` [PATCH -v3 3/3] xen-blkback: refactor vbd remove/disconnect Joe Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3BBB00.1050101@cantab.net \
--to=dvrabel@cantab.net \
--cc=Ian.Campbell@eu.citrix.com \
--cc=KURT.HACKEL@oracle.com \
--cc=annie.li@oracle.com \
--cc=daniel.stodden@citrix.com \
--cc=greg.marsden@oracle.com \
--cc=jaxboe@fusionio.com \
--cc=joe.jin@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox