From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, hpa@linux.intel.com, borislav.petkov@amd.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cpu] x86, amd: Avoid cache aliasing penalties on AMD family 15h
Date: Fri, 05 Aug 2011 17:10:12 -0700 [thread overview]
Message-ID: <4E3C8664.7050607@zytor.com> (raw)
In-Reply-To: <tip-dfb09f9b7ab03fd367740e541a5caf830ed56726@git.kernel.org>
On 08/05/2011 03:58 PM, tip-bot for Borislav Petkov wrote:
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index b13ed39..b0234bc 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -458,6 +458,19 @@ static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
> "with P0 frequency!\n");
> }
> }
> +
> + if (c->x86 == 0x15) {
> + unsigned long upperbit;
> + u32 cpuid, assoc;
> +
> + cpuid = cpuid_edx(0x80000005);
> + assoc = cpuid >> 16 & 0xff;
> + upperbit = ((cpuid >> 24) << 10) / assoc;
> +
> + va_align.mask = (upperbit - 1) & PAGE_MASK;
> + va_align.flags = ALIGN_VA_32 | ALIGN_VA_64;
> +
> + }
> }
>
> static void __cpuinit init_amd(struct cpuinfo_x86 *c)
Breaks all i386 builds:
/home/hpa/kernel/linux-tip.cpu/arch/x86/kernel/cpu/amd.c:437: undefined
reference to `va_align'
/home/hpa/kernel/linux-tip.cpu/arch/x86/kernel/cpu/amd.c:436: undefined
reference to `va_align'
[the line numbers refer to the entire patchset]
-hpa
next prev parent reply other threads:[~2011-08-06 0:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 13:15 [PATCH -v3.1 0/3] x86, AMD: Correct F15h IC aliasing issue Borislav Petkov
2011-08-05 13:15 ` [PATCH -v3.1 1/3] " Borislav Petkov
2011-08-05 22:58 ` [tip:x86/cpu] x86, amd: Avoid cache aliasing penalties on AMD family 15h tip-bot for Borislav Petkov
2011-08-06 0:10 ` H. Peter Anvin [this message]
2011-08-06 12:31 ` [PATCH] x86, AMD: Fix 32-bit build after cache aliasing patch Borislav Petkov
2011-08-06 23:22 ` [tip:x86/cpu] x86-32, amd: Move va_align definition to unbreak 32-bit build tip-bot for Borislav Petkov
2011-08-05 13:15 ` [PATCH -v3.1 2/3] x86: Add a BSP cpuinit helper Borislav Petkov
2011-08-05 13:15 ` [PATCH -v3.1 3/3] x86, AMD: Move BSP code to " Borislav Petkov
2011-08-05 17:10 ` [PATCH -v3.1 0/3] x86, AMD: Correct F15h IC aliasing issue H. Peter Anvin
2011-08-05 17:55 ` Borislav Petkov
2011-08-05 18:01 ` [PATCH -v3.2 2/3] x86: Add a BSP cpu_dev helper Borislav Petkov
2011-08-05 22:58 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2011-08-05 18:04 ` [PATCH -v3.2 3/3] x86, AMD: Move BSP code to " Borislav Petkov
2011-08-05 20:07 ` H. Peter Anvin
2011-08-05 22:52 ` Borislav Petkov
2011-08-05 22:56 ` H. Peter Anvin
2011-08-05 22:59 ` [tip:x86/cpu] x86, amd: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3C8664.7050607@zytor.com \
--to=hpa@zytor.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox