[PATCH] viafb: fix pointer type missmatch

[PATCH] viafb: fix pointer type missmatch

[stufever]

From: Wang Shaoyan <wangshaoyan.pt@taobao.com>

  drivers/video/via/via-core.c: In function 'via_pci_probe':
  drivers/video/via/via-core.c:691: warning: assignment discards qualifiers from pointer target type

Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
---
 drivers/video/via/via-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
index eb112b6..dd58b53 100644
--- a/drivers/video/via/via-core.c
+++ b/drivers/video/via/via-core.c
@@ -35,7 +35,7 @@ static struct via_port_cfg adap_configs[] = {
  * The OLPC XO-1.5 puts the camera power and reset lines onto
  * GPIO 2C.
  */
-static const struct via_port_cfg olpc_adap_configs[] = {
+static struct via_port_cfg olpc_adap_configs[] = {
 	[VIA_PORT_26]	= { VIA_PORT_I2C,  VIA_MODE_I2C, VIASR, 0x26 },
 	[VIA_PORT_31]	= { VIA_PORT_I2C,  VIA_MODE_I2C, VIASR, 0x31 },
 	[VIA_PORT_25]	= { VIA_PORT_GPIO, VIA_MODE_GPIO, VIASR, 0x25 },
-- 
1.7.0.4

Re: [PATCH] viafb: fix pointer type missmatch

[Florian Tobias Schandinat]

Hi,

On 08/06/2011 01:26 PM, stufever@gmail.com wrote:
> From: Wang Shaoyan<wangshaoyan.pt@taobao.com>
>
>    drivers/video/via/via-core.c: In function 'via_pci_probe':
>    drivers/video/via/via-core.c:691: warning: assignment discards qualifiers from pointer target type
>
> Signed-off-by: Wang Shaoyan<wangshaoyan.pt@taobao.com>
> ---
>   drivers/video/via/via-core.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
> index eb112b6..dd58b53 100644
> --- a/drivers/video/via/via-core.c
> +++ b/drivers/video/via/via-core.c
> @@ -35,7 +35,7 @@ static struct via_port_cfg adap_configs[] = {
>    * The OLPC XO-1.5 puts the camera power and reset lines onto
>    * GPIO 2C.
>    */
> -static const struct via_port_cfg olpc_adap_configs[] = {
> +static struct via_port_cfg olpc_adap_configs[] = {

Well the const was there as this object should really not be changed at runtime. 
But as the correct solution is not feasible as it conflicts with the I2C API and 
casting the const away would be evil as well I will accept this patch.
But as I assume you, who sent this email, are not the original author, please 
resent it with your Signed-off-by added. (as keeping track who received the 
patch from whom is one reasons for having those)

>   	[VIA_PORT_26]	= { VIA_PORT_I2C,  VIA_MODE_I2C, VIASR, 0x26 },
>   	[VIA_PORT_31]	= { VIA_PORT_I2C,  VIA_MODE_I2C, VIASR, 0x31 },
>   	[VIA_PORT_25]	= { VIA_PORT_GPIO, VIA_MODE_GPIO, VIASR, 0x25 },

Thanks,

Florian Tobias Schandinat

Re: [PATCH] viafb: fix pointer type missmatch

[Wang Shaoyan]

hi, the gmail is just to send patch, I have to use it, because my work
mail server will append some spam information. So my signed-off-by is
right author, that's why I add an obvious "From:". Sorry to trobule
you.

> But as I assume you, who sent this email, are not the original author,
> please resent it with your Signed-off-by added. (as keeping track who
> received the patch from whom is one reasons for having those)


-- 
Wang Shaoyan

Re: [PATCH] viafb: fix pointer type missmatch

[Florian Tobias Schandinat]

Hi,

okay, it was not obvious that "stufever@gmail.com" is the same person as "Wang 
Shaoyan". Now that I know it it's okay. Maybe you want to adjust your config 
(maybe user.name in git) to give others a hint that they are the same.
I will apply your patch to my tree when linux-next is reopened for new material 
(when -rc1 is released).


Thanks,

Florian Tobias Schandinat

On 08/06/2011 03:03 PM, Wang Shaoyan wrote:
> hi, the gmail is just to send patch, I have to use it, because my work
> mail server will append some spam information. So my signed-off-by is
> right author, that's why I add an obvious "From:". Sorry to trobule
> you.
>
>> But as I assume you, who sent this email, are not the original author,
>> please resent it with your Signed-off-by added. (as keeping track who
>> received the patch from whom is one reasons for having those)
>
>