* [PATCH] dt: add empty of_get_property for non-dt
@ 2011-08-05 22:50 Stephen Warren
2011-08-07 14:37 ` Rob Herring
2011-08-09 17:27 ` Grant Likely
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Warren @ 2011-08-05 22:50 UTC (permalink / raw)
To: Grant Likely
Cc: devicetree-discuss, Ben Dooks, Axel Lin, linux-kernel,
linux-tegra, linux-i2c, Jean Delvare, John Bonesio, Colin Cross,
Stephen Warren
The patch adds empty function of_get_property for non-dt build, so that
drivers migrating to dt can save some '#ifdef CONFIG_OF'.
This also fixes the current Tegra compile problem in linux-next.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
include/linux/of.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
index 0085bb0..9180dc5 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
return -ENOSYS;
}
+static inline const void *of_get_property(const struct device_node *node,
+ const char *name,
+ int *lenp)
+{
+ return NULL;
+}
+
#endif /* CONFIG_OF */
static inline int of_property_read_u32(const struct device_node *np,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt: add empty of_get_property for non-dt
2011-08-05 22:50 [PATCH] dt: add empty of_get_property for non-dt Stephen Warren
@ 2011-08-07 14:37 ` Rob Herring
2011-08-08 19:26 ` Stephen Warren
2011-08-09 17:27 ` Grant Likely
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2011-08-07 14:37 UTC (permalink / raw)
To: Stephen Warren
Cc: Grant Likely, devicetree-discuss, linux-kernel, Jean Delvare,
linux-i2c, Colin Cross, linux-tegra, Axel Lin, Ben Dooks
On 08/05/2011 05:50 PM, Stephen Warren wrote:
> The patch adds empty function of_get_property for non-dt build, so that
> drivers migrating to dt can save some '#ifdef CONFIG_OF'.
>
> This also fixes the current Tegra compile problem in linux-next.
>
You could just use of_property_read_u32 in the driver. It already has
empty version and will simplify the driver code some.
Rob
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> include/linux/of.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0085bb0..9180dc5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
> return -ENOSYS;
> }
>
> +static inline const void *of_get_property(const struct device_node *node,
> + const char *name,
> + int *lenp)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_OF */
>
> static inline int of_property_read_u32(const struct device_node *np,
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] dt: add empty of_get_property for non-dt
2011-08-07 14:37 ` Rob Herring
@ 2011-08-08 19:26 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2011-08-08 19:26 UTC (permalink / raw)
To: Rob Herring, Grant Likely, Ben Dooks
Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Jean Delvare, linux-i2c@vger.kernel.org, Colin Cross,
linux-tegra@vger.kernel.org, Axel Lin
Rob Herring wrote at Sunday, August 07, 2011 8:38 AM:
> On 08/05/2011 05:50 PM, Stephen Warren wrote:
> > The patch adds empty function of_get_property for non-dt build, so that
> > drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> >
> > This also fixes the current Tegra compile problem in linux-next.
>
> You could just use of_property_read_u32 in the driver. It already has
> empty version and will simplify the driver code some.
Yes, that would also work.
Grant, Ben, do you have a preference for which option to choose?
Thanks.
> > diff --git a/include/linux/of.h b/include/linux/of.h
...
> > +static inline const void *of_get_property(const struct device_node *node,
> > + const char *name,
> > + int *lenp)
> > +{
> > + return NULL;
> > +}
> > +
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt: add empty of_get_property for non-dt
2011-08-05 22:50 [PATCH] dt: add empty of_get_property for non-dt Stephen Warren
2011-08-07 14:37 ` Rob Herring
@ 2011-08-09 17:27 ` Grant Likely
1 sibling, 0 replies; 4+ messages in thread
From: Grant Likely @ 2011-08-09 17:27 UTC (permalink / raw)
To: Stephen Warren
Cc: devicetree-discuss, Ben Dooks, Axel Lin, linux-kernel,
linux-tegra, linux-i2c, Jean Delvare, John Bonesio, Colin Cross
On Fri, Aug 05, 2011 at 04:50:30PM -0600, Stephen Warren wrote:
> The patch adds empty function of_get_property for non-dt build, so that
> drivers migrating to dt can save some '#ifdef CONFIG_OF'.
>
> This also fixes the current Tegra compile problem in linux-next.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> include/linux/of.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
Merged, thanks.
g.
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0085bb0..9180dc5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
> return -ENOSYS;
> }
>
> +static inline const void *of_get_property(const struct device_node *node,
> + const char *name,
> + int *lenp)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_OF */
>
> static inline int of_property_read_u32(const struct device_node *np,
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-09 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-05 22:50 [PATCH] dt: add empty of_get_property for non-dt Stephen Warren
2011-08-07 14:37 ` Rob Herring
2011-08-08 19:26 ` Stephen Warren
2011-08-09 17:27 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox