From: "Roland Vossen" <rvossen@broadcom.com>
To: "Thomas Meyer" <thomas@m3y3r.de>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: brcm80211: use kzalloc()
Date: Mon, 8 Aug 2011 14:00:28 +0200 [thread overview]
Message-ID: <4E3FCFDC.1050000@broadcom.com> (raw)
In-Reply-To: <1312629992.5589.130.camel@localhost.localdomain>
> Signed-off-by: Thomas Meyer<thomas@m3y3r.de>
Acked-by: Roland Vossen <rvossen@broadcom.com>
> ---
>
> diff -u -p a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c 2011-07-28 15:32:17.863253745 +0200
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c 2011-08-01 20:25:55.608031978 +0200
> @@ -6326,14 +6326,12 @@ brcmf_sdbrcm_chip_attach(struct brcmf_bu
> BRCMF_TRACE(("%s: Enter\n", __func__));
>
> /* alloc chip_info_t */
> - ci = kmalloc(sizeof(struct chip_info), GFP_ATOMIC);
> + ci = kzalloc(sizeof(struct chip_info), GFP_ATOMIC);
> if (NULL == ci) {
> BRCMF_ERROR(("%s: malloc failed!\n", __func__));
> return -ENOMEM;
> }
>
> - memset((unsigned char *)ci, 0, sizeof(struct chip_info));
> -
> /* bus/core/clk setup for register access */
> /* Try forcing SDIO core to do ALPAvail request only */
> clkset = SBSDIO_FORCE_HW_CLKREQ_OFF | SBSDIO_ALP_AVAIL_REQ;
>
>
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
prev parent reply other threads:[~2011-08-08 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 11:26 [PATCH] staging: brcm80211: use kzalloc() Thomas Meyer
2011-08-08 12:00 ` Roland Vossen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3FCFDC.1050000@broadcom.com \
--to=rvossen@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox