From: Cong Wang <amwang@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Paul Clements <Paul.Clements@steeleye.com>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] nbd: some trivial improvements
Date: Tue, 09 Aug 2011 15:16:20 +0800 [thread overview]
Message-ID: <4E40DEC4.5040401@redhat.com> (raw)
In-Reply-To: <20110808172040.GA3191@suse.de>
于 2011年08月09日 01:20, Greg KH 写道:
> On Mon, Aug 08, 2011 at 05:00:04PM +0800, Amerigo Wang wrote:
>> This patch 1) uses task_pid_nr(current) to get the pid of current process,
>> 2) replaces sysfs_create_file() with device_create_file(), 3) lower
>> the loglevel of an error message.
>
> As you are doing 3 different things, please make this 3 different
> patches (remember, one patch per logical thing being done.)
Since you insist, will do.
>
>>
>> if (max_part< 0) {
>> - printk(KERN_CRIT "nbd: max_part must be>= 0\n");
>> + printk(KERN_ERR "nbd: max_part must be>= 0\n");
>
> Again, dev_err() please. That properly identifies exactly which device
> had problems.
>
Ok, thanks for pointing this out!
prev parent reply other threads:[~2011-08-09 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 9:00 [PATCH] nbd: some trivial improvements Amerigo Wang
2011-08-08 16:37 ` Joe Perches
2011-08-09 7:13 ` Cong Wang
2011-08-08 17:20 ` Greg KH
2011-08-09 7:16 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E40DEC4.5040401@redhat.com \
--to=amwang@redhat.com \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox