From: Mayank Rungta <mr.mynk@gmail.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
yakui.zhao@intel.com, ajax@redhat.com, airlied@redhat.com,
airlied@linux.ie
Cc: "A.R Karthick" <a.r.karthick@gmail.com>,
karthick.linuxdreamer@gmail.com, Self <mr.mynk@gmail.com>
Subject: [PATCH 2.6.38-10-generic] device driver: fix oops in radeon driver due to incorrect value from hardware
Date: Tue, 09 Aug 2011 23:52:48 +0530 [thread overview]
Message-ID: <4E417AF8.7090202@gmail.com> (raw)
Added a check for the radeon ring buffer write index in r600.c which
reads 0xffffffff on resume. This results in an Oops during
radeon_ring_write. Masking the value averts this.
This problem is not seen to be fixed in 3.0 r600.c as well.
Detailed analysis of the problem can be found at -
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/820746/
---
BUG: unable to handle kernel paging request at fa501ffc - Oops at
r600_cp_start+0x48/0x380 in r600_cp_resume+0x345/0x580 [radeon]
drivers/gpu/drm/radeon/r600.c
--- linux-2.6.38/drivers/gpu/drm/radeon/r600.c.orig 2011-08-05
15:39:40.824612700 +0530
+++ linux-2.6.38/drivers/gpu/drm/radeon/r600.c 2011-08-08
05:29:21.744417857 +0530
@@ -2218,6 +2218,8 @@ int r600_cp_resume(struct radeon_device
rdev->cp.rptr = RREG32(CP_RB_RPTR);
rdev->cp.wptr = RREG32(CP_RB_WPTR);
+ /* protect against crazy HW on resume */
+ rdev->cp.wptr &= rdev->cp.ptr_mask;
r600_cp_start(rdev);
rdev->cp.ready = true;
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: A R Karthick <a.r.karthick@gmail.com>
Reported-by: Mayank Rungta <mr.mynk@gmail.com>
Tested-by: Mayank Rungta <mr.mynk@gmail.com>
next reply other threads:[~2011-08-09 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 18:22 Mayank Rungta [this message]
2011-08-10 9:24 ` [PATCH 2.6.38-10-generic] device driver: fix oops in radeon driver due to incorrect value from hardware Michel Dänzer
2011-08-10 9:46 ` Mayank Rungta
2011-08-10 13:27 ` Alex Deucher
2011-09-08 13:50 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E417AF8.7090202@gmail.com \
--to=mr.mynk@gmail.com \
--cc=a.r.karthick@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karthick.linuxdreamer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox