From: Lars-Peter Clausen <lars@metafoo.de>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Mike Frysinger <vapier.adi@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [alsa-devel] [PATCH 3/4] ASoC: Blackfin: ADAU1373 eval board support
Date: Wed, 10 Aug 2011 08:09:55 +0200 [thread overview]
Message-ID: <4E4220B3.7020105@metafoo.de> (raw)
In-Reply-To: <CAHG8p1CuiJws=wSKrfAiY9E=rne=taPP-semYZQJWuHn19398w@mail.gmail.com>
On 08/10/2011 07:27 AM, Scott Jiang wrote:
>> +config SND_SOC_BFIN_EVAL_ADAU1373
>> + tristate "Support for the EVAL-ADAU1373 board on Blackfin eval boards"
>> + depends on SND_BF5XX_I2S
>> + select SND_BF5XX_SOC_I2S
>> + select SND_SOC_ADAU1373
>> + select I2C
>
> Is it better to use depends on I2C?
>
Not sure, I just kept the scheme used by the other blackfin board drivers. But
I guess it makes some sense change it to 'depends'. Especially if we consider
that there are going to be board drivers with support for both I2C and SPI.
- Lars
next prev parent reply other threads:[~2011-08-10 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 3:52 [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch Lars-Peter Clausen
2011-08-10 3:52 ` [PATCH 2/4] ASoC: Add ADAU1373 codec support Lars-Peter Clausen
2011-08-10 6:11 ` Lars-Peter Clausen
2011-08-11 9:27 ` Mark Brown
2011-08-11 10:11 ` Lars-Peter Clausen
2011-08-11 13:16 ` Mark Brown
2011-08-12 0:20 ` Lars-Peter Clausen
2011-08-12 1:20 ` Mark Brown
2011-08-13 3:25 ` Lars-Peter Clausen
2011-08-14 10:24 ` Mark Brown
2011-08-10 3:52 ` [PATCH 3/4] ASoC: Blackfin: ADAU1373 eval board support Lars-Peter Clausen
2011-08-10 5:27 ` [alsa-devel] " Scott Jiang
2011-08-10 6:09 ` Lars-Peter Clausen [this message]
2011-08-10 3:52 ` [PATCH 4/4] Blackfin: bf537: Stamp: Register ASoC EVAL-ADAU1373 board driver Lars-Peter Clausen
2011-08-11 9:31 ` [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch Mark Brown
2011-08-11 9:59 ` [alsa-devel] " Lars-Peter Clausen
2011-08-12 1:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4220B3.7020105@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox