public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bob Pearson <rpearson@systemfabricworks.com>
To: linux-kernel@vger.kernel.org, joakim.tjernlund@transmode.se,
	akpm@linux-foundation.org, linux@horizon.com,
	fzago@systemfabricworks.com
Subject: [patch v5 5/8] crc32-fix-check-endian-warnings.diff
Date: Wed, 10 Aug 2011 17:44:32 -0500	[thread overview]
Message-ID: <4E4309D0.5070203@systemfabricworks.com> (raw)
In-Reply-To: <20110810222018.281901163@systemfabricworks.com>

crc32.c freely mixes u32, __le32 and __be32 types. Fix warnings from
sparse with "-D__CHECK_ENDIAN__" by some emphatic casts.

Signed-off-by: Bob Pearson <rpearson@systemfabricworks.com>

---
 lib/crc32.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Index: infiniband/lib/crc32.c
===================================================================
--- infiniband.orig/lib/crc32.c
+++ infiniband/lib/crc32.c
@@ -26,13 +26,13 @@
 #include "crc32defs.h"
  #if CRC_LE_BITS == 8
-# define tole(x) __constant_cpu_to_le32(x)
+# define tole(x) (__force u32) __constant_cpu_to_le32(x)
 #else
 # define tole(x) (x)
 #endif
  #if CRC_BE_BITS == 8
-# define tobe(x) __constant_cpu_to_be32(x)
+# define tobe(x) (__force u32) __constant_cpu_to_be32(x)
 #else
 # define tobe(x) (x)
 #endif
@@ -126,9 +126,9 @@ u32 __pure crc32_le(u32 crc, unsigned ch
 # elif CRC_LE_BITS == 8
 	const u32      (*tab)[] = crc32table_le;
 -	crc = __cpu_to_le32(crc);
+	crc = (__force u32) __cpu_to_le32(crc);
 	crc = crc32_body(crc, p, len, tab);
-	crc = __le32_to_cpu(crc);
+	crc = __le32_to_cpu((__force __le32)crc);
 #endif
 	return crc;
 }
@@ -169,9 +169,9 @@ u32 __pure crc32_be(u32 crc, unsigned ch
 # elif CRC_BE_BITS == 8
 	const u32      (*tab)[] = crc32table_be;
 -	crc = __cpu_to_be32(crc);
+	crc = (__force u32) __cpu_to_be32(crc);
 	crc = crc32_body(crc, p, len, tab);
-	crc = __be32_to_cpu(crc);
+	crc = __be32_to_cpu((__force __be32)crc);
 # endif
 	return crc;
 }



  parent reply	other threads:[~2011-08-10 22:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110810222018.281901163@systemfabricworks.com>
2011-08-10 22:43 ` [patch v5 1/8] crc32-add-pointer-to-tab.diff Bob Pearson
2011-08-10 22:43 ` [patch v5 2/8] crc32-move-to-documentation.diff Bob Pearson
2011-08-10 22:44 ` [patch v5 3/8] crc32-replace-self-test.diff Bob Pearson
2011-08-10 22:44 ` [patch v5 4/8] crc32-misc-cleanup.diff Bob Pearson
2011-08-10 22:44 ` Bob Pearson [this message]
2011-08-10 22:44 ` [patch v5 6/8] crc32-add-real-8-bit.diff Bob Pearson
2011-08-10 22:44 ` [patch v5 7/8] crc32-add-slicing-by-8.diff Bob Pearson
2011-08-11 13:46   ` Joakim Tjernlund
2011-08-11 15:34   ` George Spelvin
2011-09-07 10:39     ` Joakim Tjernlund
2011-08-10 22:45 ` [patch v5 8/8] crc32-final-cleanup.diff Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4309D0.5070203@systemfabricworks.com \
    --to=rpearson@systemfabricworks.com \
    --cc=akpm@linux-foundation.org \
    --cc=fzago@systemfabricworks.com \
    --cc=joakim.tjernlund@transmode.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox