Re: [PATCH 0/5][RFC] kprobes/ftrace: Have kprobes use ftrace on ftrace nops

Steven Rostedt
2011-08-12T13:09:02Z

On Fri, 2011-08-12 at 11:57 +0900, Masami Hiramatsu wrote:

> I don't think it won't work. It can work but on a long way.
> Could you tell me your "bigger ideas"? Perhaps, we are on the different
> way but aim to same goal.

Part of the bigger ideas is to have things like function graph tracing
use this, as it will simplify the entry.S code. There's other things
that may come out of this too.

>
> >> The cons:
> >> - Native kprobes users will be disappointed... anyway, they just need to
> >> move their probes to the next instruction (usually addr+=5 is OK).
> >
> > I've been told that doing the addr+=5 (which is also arch specific) can
> > break things for other tools.
>
> As I told in previous mail, I think kprobes can do that transparently.

Yeah, it could, but I'm afraid this may need to be done differently for
every arch. If I'm working on getting this code to work for ftrace,
which will require modifying ever arch as well, kprobes can get the
changes for free.

-- Steve