From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064Ab1HKEzV (ORCPT ); Thu, 11 Aug 2011 00:55:21 -0400 Received: from mail-iy0-f170.google.com ([209.85.210.170]:35888 "EHLO mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771Ab1HKEzS (ORCPT ); Thu, 11 Aug 2011 00:55:18 -0400 Message-ID: <4E435FDF.9030304@gmail.com> Date: Wed, 10 Aug 2011 22:51:43 -0600 From: David Ahern User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, acme@redhat.com, fweisbec@gmail.com, penberg@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@elte.hu CC: linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/urgent] perf symbols: Check '/tmp/perf-' symbol file ownership References: <1312919658-17158-1-git-send-email-penberg@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2011 03:48 AM, tip-bot for Pekka Enberg wrote: > Commit-ID: 981c1252691f4b855f2bb47ea93fb6052ea3aee2 > Gitweb: http://git.kernel.org/tip/981c1252691f4b855f2bb47ea93fb6052ea3aee2 > Author: Pekka Enberg > AuthorDate: Tue, 9 Aug 2011 22:54:18 +0300 > Committer: Arnaldo Carvalho de Melo > CommitDate: Tue, 9 Aug 2011 15:23:08 -0300 > > perf symbols: Check '/tmp/perf-' symbol file ownership > > The external symbol files are generated by JIT compilers, for example, but we > need to make sure they're ours before injecting them to 'perf report'. > > Requested-by: Ingo Molnar > Cc: Frederic Weisbecker > Cc: Peter Zijlstra > Link: http://lkml.kernel.org/r/1312919658-17158-1-git-send-email-penberg@kernel.org > Signed-off-by: Pekka Enberg > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/util/symbol.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c > index eec1963..a8b5371 100644 > --- a/tools/perf/util/symbol.c > +++ b/tools/perf/util/symbol.c > @@ -1504,6 +1504,17 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) > dso->adjust_symbols = 0; > > if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { > + struct stat st; > + > + if (stat(dso->name, &st) < 0) > + return -1; > + > + if (st.st_uid && (st.st_uid != geteuid())) { > + pr_warning("File %s not owned by current user or root, " > + "ignoring it.\n", dso->name); > + return -1; > + } Is the force option relevant here -- similar to perf_session__open()? David > + > ret = dso__load_perf_map(dso, map, filter); > dso->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT : > SYMTAB__NOT_FOUND; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/