From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Tony Luck <tony.luck@intel.com>
Cc: Thomas Meyer <thomas@m3y3r.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Julia Lawall <julia@diku.dk>
Subject: Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c?
Date: Thu, 11 Aug 2011 08:12:45 +0200 [thread overview]
Message-ID: <4E4372DD.6020603@redhat.com> (raw)
In-Reply-To: <CA+8MBbJDLrNHD0kGdYNv1WPnRh8G1aEY-T3xcS_wMpciTVcy7A@mail.gmail.com>
On 08/08/11 23:37, Tony Luck wrote:
> On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu().
>>
>> Or is this done in another function? I didn't find it.
>
> It would be hard to do it elsewhere - this function may not have done
> a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case].
>
> The logic is a bit tortuous here ... perhaps simpler to split the tests
> up. Does the attached patch look right?
Hi Tony,
You probably want someone from SGI to look at it, so I'll forward to
Robin Holt.
I haven't been at SGI for about 2 years now :)
Cheers,
Jes
next prev parent reply other threads:[~2011-08-11 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 18:05 Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c? Thomas Meyer
2011-08-08 21:37 ` Tony Luck
2011-08-11 6:12 ` Jes Sorensen [this message]
2011-08-11 10:58 ` Robin Holt
2011-08-11 13:59 ` Jack Steiner
2011-08-13 7:37 ` Thomas Meyer
2011-08-20 4:04 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4372DD.6020603@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox