From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754417Ab1HKI54 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Aug 2011 04:57:56 -0400
Received: from e28smtp07.in.ibm.com ([122.248.162.7]:56014 "EHLO
	e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753279Ab1HKI5z (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Aug 2011 04:57:55 -0400
Message-ID: <4E439962.4040105@linux.vnet.ibm.com>
Date: Thu, 11 Aug 2011 14:27:06 +0530
From: Raghavendra K T <raghukt@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11
MIME-Version: 1.0
To: Michal Hocko <mhocko@suse.cz>
CC: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
        Arend van Spriel <arend@broadcom.com>,
        Greg Kroah-Hartman <gregkh@suse.de>,
        "David S. Miller" <davem@davemloft.net>,
        "nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
        Balbir Singh <bsingharora@gmail.com>,
        "John W. Linville" <linville@tuxdriver.com>,
        Mauro Carvalho Chehab <mchehab@redhat.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        Ying Han <yinghan@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg
References: <20110810172917.23280.9440.sendpatchset@oc5400248562.ibm.com> <20110810172929.23280.76419.sendpatchset@oc5400248562.ibm.com> <20110811080447.GB8023@tiehlicka.suse.cz>
In-Reply-To: <20110811080447.GB8023@tiehlicka.suse.cz>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/11/2011 01:34 PM, Michal Hocko wrote:
> On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
> [...]
>> This patch renames all mem variables to memcg in source file.
>
> __mem_cgroup_try_charge for example uses local mem which cannot be
> renamed because it already has a memcg argument (mem_cgroup **) then we
> have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
> use mem_cgroup **ptr (I guess we shouldn't have more of them).
> I think that __mem_cgroup_try_charge should use ptr pattern as well.
> Other than that I think the clean up is good.
>
> With __mem_cgroup_try_charge:
> Acked-by: Michal Hocko<mhocko@suse.cz>
>
> Thanks
Agreed, Let me know whether you prefer whole patch to be posted or only 
the corresponding hunk.
Thanks