From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479Ab1HKRJv (ORCPT ); Thu, 11 Aug 2011 13:09:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423Ab1HKRJm (ORCPT ); Thu, 11 Aug 2011 13:09:42 -0400 Message-ID: <4E4408D9.4050706@redhat.com> Date: Thu, 11 Aug 2011 12:52:41 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: Mel Gorman CC: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Minchan Kim Subject: Re: [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback References: <1312973240-32576-1-git-send-email-mgorman@suse.de> <1312973240-32576-3-git-send-email-mgorman@suse.de> In-Reply-To: <1312973240-32576-3-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2011 06:47 AM, Mel Gorman wrote: > Lumpy reclaim worked with two passes - the first which queued pages for > IO and the second which waited on writeback. As direct reclaim can no > longer write pages there is some dead code. This patch removes it but > direct reclaim will continue to wait on pages under writeback while in > synchronous reclaim mode. > > Signed-off-by: Mel Gorman Reviewed-by: Rik van Riel