Re: [PATCH] EDAC: Correct Kconfig dependencies

Randy Dunlap
2011-08-10T17:14:33Z

On Wed, 10 Aug 2011 14:43:30 +0200 Borislav Petkov wrote:

> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Both AMD and Intel i7 EDAC drivers use MCE features and are thus
> dependent of this functionality present in the kernel. Express this in
> Kconfig so that randconfig builds don't break.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
> drivers/edac/Kconfig | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index f888fb5..d057d6c 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -41,7 +41,7 @@ config EDAC_DEBUG
>
> config EDAC_DECODE_MCE
> tristate "Decode MCEs in human-readable form (only on AMD for now)"
> - depends on CPU_SUP_AMD && X86_MCE
> + depends on CPU_SUP_AMD && X86_MCE_AMD
> default y
> ---help---
> Enable this option if you want to decode Machine Check Exceptions
> @@ -170,8 +170,7 @@ config EDAC_I5400
>
> config EDAC_I7CORE
> tristate "Intel i7 Core (Nehalem) processors"
> - depends on EDAC_MM_EDAC && PCI && X86
> - select EDAC_MCE
> + depends on EDAC_MM_EDAC && PCI && X86 && X86_MCE_INTEL
> help
> Support for error detection and correction the Intel
> i7 Core (Nehalem) Integrated Memory Controller that exists on
> --
> 1.7.4.rc2
>

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***