From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631Ab1HLAXO (ORCPT ); Thu, 11 Aug 2011 20:23:14 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:52624 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563Ab1HLAXN (ORCPT ); Thu, 11 Aug 2011 20:23:13 -0400 Message-ID: <4E4471E1.5060706@metafoo.de> Date: Fri, 12 Aug 2011 02:20:49 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110702 Icedove/3.0.11 MIME-Version: 1.0 To: Mark Brown CC: Liam Girdwood , alsa-devel@alsa-project.org, device-drivers-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org, Mike Frysinger Subject: Re: [PATCH 2/4] ASoC: Add ADAU1373 codec support References: <1312948364-2587-1-git-send-email-lars@metafoo.de> <1312948364-2587-2-git-send-email-lars@metafoo.de> <20110811092702.GA18454@opensource.wolfsonmicro.com> <4E43AACF.5060701@metafoo.de> <1313068590.19990.2.camel@finisterre.wolfsonmicro.main> In-Reply-To: <1313068590.19990.2.camel@finisterre.wolfsonmicro.main> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2011 03:16 PM, Mark Brown wrote: > On Thu, 2011-08-11 at 12:11 +0200, Lars-Peter Clausen wrote: >>>> + SOC_ENUM("Lineout1 Mono Stereo", adau1373_lineout1_mode_enum), >>>> + SOC_ENUM("Speaker Mono Stereo", adau1373_speaker_mode_enum), > >>> I'd expect these to be platform data/machine data rather than user >>> control? The speaker wiring isn't going to vary dynamically... > >> You still might want to switch, for whatever particular reason, between mono >> and stereo at runtime. > > Sorry, what does this actually control? I guess I've been mislead but > from the name of the control I'd expect it to control if the outputs > were physically connected as mono or stereo outputs. It controls how Lineout and Speaker mixers distribute the left and right input channels to their output channels. > >>>> + switch (freq / params_rate(params)) { >>>> + case 1024: /* fs */ >>>> + div = 0; >>>> + break; >>>> + case 1536: /* 2/3 fs */ >>>> + div = 1; >>>> + break; > >>> These comments look inaccuate, fs is the sample rate so a divide of 1 >>> would be fs. > >> div contains the register value representation of that particular divider. > > div isn't the issue here. The comments seem to indicate that the result > of the divisions are some multiple of fs but fs usually means some > multiple of the sample rate. For example 2/3fs for 44.1kHz would be > 29.4kHz. > Ah, ok. Yes, I guess the comments are a bit confusing since fs refers to the internal sample rate and not to the sample rate of the DAI. I'll try to clarify it.