public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: stufever@gmail.com, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, gregkh@suse.de,
	michael.hennerich@analog.com,
	Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c
Date: Fri, 12 Aug 2011 15:21:50 +0100	[thread overview]
Message-ID: <4E4536FE.40502@cam.ac.uk> (raw)
In-Reply-To: <4E44E99E.3070302@cam.ac.uk>

On 08/12/11 09:51, Jonathan Cameron wrote:
> On 08/06/11 19:09, stufever@gmail.com wrote:
>> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
>>
>>   drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
>>   drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
>>
>> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
> As with other one, this is fixed in iio-blue.git, but I'm happy to see either version merge.
I'm dozing.  This is the third fix for this one.  Greg, pick up which ever one you want!
>>
>> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>> ---
>>  drivers/staging/iio/dac/ad5791.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
>> index 64770d2..5b00b70 100644
>> --- a/drivers/staging/iio/dac/ad5791.c
>> +++ b/drivers/staging/iio/dac/ad5791.c
>> @@ -381,7 +381,6 @@ error_put_reg_pos:
>>  	if (!IS_ERR(reg_vdd))
>>  		regulator_put(reg_vdd);
>>  
>> -error_ret:
>>  	return ret;
>>  }
>>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2011-08-12 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-06 18:09 [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c stufever
2011-08-12  8:51 ` Jonathan Cameron
2011-08-12 14:21   ` Jonathan Cameron [this message]
2011-08-23 20:39     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4536FE.40502@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=gregkh@suse.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=stufever@gmail.com \
    --cc=wangshaoyan.pt@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox