From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754842Ab1HNTLU (ORCPT ); Sun, 14 Aug 2011 15:11:20 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:64061 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754653Ab1HNTLU (ORCPT ); Sun, 14 Aug 2011 15:11:20 -0400 Message-ID: <4E481DD3.404@landley.net> Date: Sun, 14 Aug 2011 14:11:15 -0500 From: Rob Landley User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Stefan Richter CC: linux-kernel@vger.kernel.org, Artem Bityutskiy , Adrian Hunter , busybox@busybox.net Subject: Re: [BUG] Linux 3.0 commit 3627924acf70a broke include/mtd/ubi_user.h. References: <4E4809BF.6040707@landley.net> <20110814200322.3fa7109d@stein> In-Reply-To: <20110814200322.3fa7109d@stein> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2011 01:03 PM, Stefan Richter wrote: > On Aug 14 Rob Landley wrote: >> "make headers_install" copies include/mtd/ubi_user.h to userspace, where >> things like busybox link against it. With 3.0, building defconfig >> busybox gets this error: >> >> In file included from miscutils/ubi_tools.c:63: >> /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:329: >> error: conflicting types for '__packed' >> /home/landley/aboriginal/aboriginal/build/simple-cross-compiler-i686/bin/../include/mtd/ubi-user.h:313: >> error: previous declaration of '__packed' was here >> >> This is due to the Linux 3.0 commit in the title: >> >> UBI: use __packed instead of __attribute__((packed)) >> >> This relies on __packed being defined in: >> >> include/linux/compiler-gcc.h: >> #define __packed __attribute__((packed)) >> >> Which is not exported to userspace. >> >> I.E. this "cleanup" broke the ability for userspace to use this header, >> even though the header is exported to userspace by headers_install. > > As far as I can tell, the __packed or __attribute__((packed)) > qualifications are superfluous in include/mtd/ubi-user.h anyway. And the email address he signed-off-by the broken commit from bounced, trying again with the one out of MAINTAINERS. Rob