From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/20] drivers_base: platform: use always ->name for uevent
Date: Mon, 15 Aug 2011 17:13:40 +0200 [thread overview]
Message-ID: <4E4937A4.5070204@linutronix.de> (raw)
In-Reply-To: <CACxGe6us1vaUgMmiZR-D9iSCQdw+vbVyZdBCkET_9p3AGyHwRQ@mail.gmail.com>
Grant Likely wrote:
>> --- a/drivers/base/platform.c
>> +++ b/drivers/base/platform.c
>> @@ -614,7 +614,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env)
>> return rc;
>>
>> add_uevent_var(env, "MODALIAS=%s%s", PLATFORM_MODULE_PREFIX,
>> - (pdev->id_entry) ? pdev->id_entry->name : pdev->name);
>> + pdev->name);
>
> Yes, this looks like the right thing to do to me. Also, I think the
> original code is suspect because it causes the uevent data to be
> different after binding a driver to a device.
Why different? The code matches (pdev->name == id->name) or
(pdev->name == driver->name) so in both cases it should be equal to
pdev->name.
Are you or Greg taking this?
> g.
Sebastian
next prev parent reply other threads:[~2011-08-15 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1313419901-13492-1-git-send-email-bigeasy@linutronix.de>
2011-08-15 14:51 ` [PATCH 01/20] drivers_base: platform: use always ->name for uevent Sebastian Andrzej Siewior
2011-08-15 14:56 ` Grant Likely
2011-08-15 15:13 ` Sebastian Andrzej Siewior [this message]
2011-08-15 15:17 ` Grant Likely
2011-08-15 15:17 ` Grant Likely
2011-08-22 21:41 ` Sarah Sharp
2011-08-22 21:51 ` Greg KH
2011-08-23 9:50 ` Sebastian Andrzej Siewior
2011-08-23 15:32 ` Greg KH
2011-09-30 13:29 ` Felipe Balbi
2011-09-30 17:09 ` Greg KH
2011-09-30 17:40 ` Felipe Balbi
2011-09-30 17:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4937A4.5070204@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox