From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526Ab1HOSoO (ORCPT ); Mon, 15 Aug 2011 14:44:14 -0400 Received: from natasha.panasas.com ([67.152.220.90]:60814 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770Ab1HOSoN (ORCPT ); Mon, 15 Aug 2011 14:44:13 -0400 Message-ID: <4E4968F0.9050108@panasas.com> Date: Mon, 15 Aug 2011 11:44:00 -0700 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Maxin B John CC: , Benny Halevy , "James E.J. Bottomley" , , , Subject: Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library References: <20110811142749.GA26109@maxin> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2011 04:18 PM, Maxin B John wrote: > Ping.. > > On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John wrote: >> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this >> in Kconfig so that the requirements are met automatically. >> >> Signed-off-by: Maxin B. John Yes sorry. It was on my todo and I never got to it. OK So actually current osd_initiator code does not use these libraries. It should, and I have very old code that started on that (hence the comment), but it was never submitted to Kernel. The OSD protocol calls for all kind of security levels that use these, but the current code only supports NO_SEC. I will keep your patch for when security code goes in. Meanwhile I should at least remove the stale comment. Thanks Boaz >> --- >> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig >> index 861b5ce..1535fe1 100644 >> --- a/drivers/scsi/osd/Kconfig >> +++ b/drivers/scsi/osd/Kconfig >> @@ -11,17 +11,16 @@ >> # it under the terms of the GNU General Public version 2 License as >> # published by the Free Software Foundation >> # >> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow. >> -# How is it done properly? >> # >> >> config SCSI_OSD_INITIATOR >> tristate "OSD-Initiator library" >> depends on SCSI >> + select CRYPTO >> + select CRYPTO_SHA1 >> + select CRYPTO_HMAC >> help >> Enable the OSD-Initiator library (libosd.ko). >> - NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their >> - dependencies >> >> config SCSI_OSD_ULD >> tristate "OSD Upper Level driver" >>