From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181Ab1HQKtO (ORCPT ); Wed, 17 Aug 2011 06:49:14 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:44515 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821Ab1HQKtL (ORCPT ); Wed, 17 Aug 2011 06:49:11 -0400 Message-ID: <4E4B9CEF.2060201@gmail.com> Date: Wed, 17 Aug 2011 13:50:23 +0300 From: Dmitry Kasatkin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: James Morris CC: Dmitry Kasatkin , linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com Subject: Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/11 03:57, James Morris wrote: > On Thu, 11 Aug 2011, Dmitry Kasatkin wrote: > >> From: Dmitry Kasatkin >> >> Adds the multi-precision-integer maths library which was originally taken >> from GnuPG and ported to the kernel by (among others) David Howells. >> This version is taken from Fedora kernel 2.6.32-71.14.1.el6. > > First thing -- this code needs to be formatted using kernel coding style. > > > - James The code is inherited from GnuPG which does not follow kernel coding standard. There are lots of "checkpatch" errors and warnings.. Do you say it must be reformatted? - Dmitry