Re: [PATCH 5/6] Input: elantech - clean up elantech_init

Wanlong Gao
2011-08-18T07:59:58Z

On 08/18/2011 09:57 AM, JJ Ding wrote:
> if (elantech_set_absolute_mode(psmouse)) {
> pr_err("failed to put touchpad into absolute mode.\n");
> goto init_fail;
Hi JJ,
--
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index e13a719..675c236 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1069,7 +1069,7 @@ int elantech_init(struct psmouse *psmouse)

return 0;

- init_fail:
+init_fail:
kfree(etd);
return -1;
}
--

also has space before *init_fail*, you may do this in your next version.

Thanks
-Wanlong Gao