Re: [PATCH 6/6] Input: elantech - add v3 hardware support

Wanlong Gao
2011-08-19T00:16:34Z

On 08/18/2011 10:25 PM, Seth Forshee wrote:
> On Thu, Aug 18, 2011 at 08:58:53AM -0500, Seth Forshee wrote:
>> The case 3 code is nearly identical to case 2. How about this?
>>
>> case 2:
>> __set_bit(BTN_TOOL_QUADTAP, dev->keybit);
>> /* fall through */
>>
>> case 3:
>> input_set_abs_params(dev, ABS_X, x_min, x_max, 0, 0);
>> input_set_abs_params(dev, ABS_Y, y_min, y_max, 0, 0);
>> /* range of pressure and width is the same as v2 */
>> input_set_abs_params(dev, ABS_PRESSURE, ETP_PMIN_V2,
>> ETP_PMAX_V2, 0, 0);
>> input_set_abs_params(dev, ABS_TOOL_WIDTH, ETP_WMIN_V2,
>> ETP_WMAX_V2, 0, 0);
>> __set_bit(INPUT_PROP_SEMI_MT, dev->propbit);
>> input_mt_init_slots(dev, 2);
>> input_set_abs_params(dev, ABS_MT_POSITION_X, x_min, x_max, 0, 0);
>> input_set_abs_params(dev, ABS_MT_POSITION_Y, y_min, y_max, 0, 0);
>> break;
>
> Sorry, that should have been:
>
> case 2:
> __set_bit(BTN_TOOL_QUADTAP, dev->keybit);
> /* fall through */
>
> case 3:
> input_set_abs_params(dev, ABS_X, x_min, x_max, 0, 0);
> input_set_abs_params(dev, ABS_Y, y_min, y_max, 0, 0);
> if (etd->reports_pressure) {
> input_set_abs_params(dev, ABS_PRESSURE, ETP_PMIN_V2,
> ETP_PMAX_V2, 0, 0);
> input_set_abs_params(dev, ABS_TOOL_WIDTH, ETP_WMIN_V2,
> ETP_WMAX_V2, 0, 0);
> }
> __set_bit(INPUT_PROP_SEMI_MT, dev->propbit);
> input_mt_init_slots(dev, 2);
> input_set_abs_params(dev, ABS_MT_POSITION_X, x_min, x_max, 0, 0);
> input_set_abs_params(dev, ABS_MT_POSITION_Y, y_min, y_max, 0, 0);
> break;

simplify, seems good.

Thanks
-Wanlong Gao
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>