Re: [PATCH 4/6] Input: elantech - work around EC buffer

Wanlong Gao
2011-08-18T06:56:05Z

On 08/18/2011 02:48 PM, JJ Ding wrote:
> Hi Wanlong Gao,
>
> On Thu, 18 Aug 2011 11:07:23 +0800, Wanlong Gao<gaowanlong@cn.fujitsu.com> wrote:
>> On 08/18/2011 09:57 AM, JJ Ding wrote:
>>>
>>> return PSMOUSE_FULL_PACKET;
>>> +
>>> + bad_packet:
>> You may introduce space here.
> Sorry, I am following you here.
> Do you want me to add one more line below bad_packet:,
> or you want me to remove the space before bad_packet?
>
> I keep that space to make the goto tags look consistent with other
> places in this file.
>
> Should I remove all starting spaces in goto tags in the file?
>
> Thanks,
>
> jj

aha, I see that some with space but some without.
Now, I'm not sure....;)

Thanks
-Wanlong Gao
>
>>> + memmove(psmouse->packet, psmouse->packet + 1, psmouse->pktsize - 1);
>>> + psmouse->pktcnt--;
>>> + return PSMOUSE_GOOD_DATA;
>>> }
>>>
>>> /*
>>
>>
>> --
>> Thanks
>> Wanlong Gao
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>