Re: [PATCH 2/6] Input: elantech - use firmware provided x, y ranges

JJ Ding
2011-08-19T09:44:58Z

Hi Dmitry,

Sorry for late reply. I missed this one somehow.

On Thu, 18 Aug 2011 00:47:56 -0700, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Thu, Aug 18, 2011 at 09:57:05AM +0800, JJ Ding wrote:
> > +
> > + i = (etd->fw_version > 0x020800 &&
> > + etd->fw_version < 0x020900) ? 1 : 2;
> > + *x_max = (etd->capabilities[1] - i) * 64;
> > + *y_max = (etd->capabilities[2] - i) * 64;
> > + *y_2ft_max = (*y_max - i) * 64 / 4;
>
> Hmm, we should have the same range for ST and MT data and scale MT data
> if it has lower resolution to match ST.
So I should just remove y_2ft_max and those ETP_2FT_XXXX in elantech.h,
and do the scale in elantech_report_absolute_v2?

If so, I will create another patch for this change.

Is this OK with you?

Thanks.
jj
> Thanks.
>
> --
> Dmitry