From: Daniel Lezcano <daniel.lezcano@free.fr>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
akpm@linux-foundation.org, bonbons@linux-vserver.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot
Date: Fri, 19 Aug 2011 01:46:41 +0200 [thread overview]
Message-ID: <4E4DA461.8030006@free.fr> (raw)
In-Reply-To: <20110815144744.GA9660@redhat.com>
On 08/15/2011 04:47 PM, Oleg Nesterov wrote:
> On 08/14, Serge E. Hallyn wrote:
>> Quoting Oleg Nesterov (oleg@redhat.com):
>>> On 08/11, Daniel Lezcano wrote:
>>>> In the case of a VPS, when we shutdown/halt/reboot the container, the
>>>> reboot utility will invoke the sys_reboot syscall which has the bad
>>>> effect to reboot the host.
>>> Stupid question. Can't sys_reboot() simply kill init (and thus the whole
>>> pid_ns) in this case?
>> The goal is to be able to distinguish a request for reboot from shutdown.
>> If we just kill the init, then the parent of init (the container monitor)
>> cannot restart the container to emulate reboot.
> OK, thanks.
>
> What if init reports the reason it was killed?
>
> Ignoring LINUX_REBOOT_CMD_CAD_/etc, I mean, roughly,
>
> - add "int reboot_cmd" into struct pid_namespace
>
> - sys_reboot(cmd) does
>
> if (!global_namespace) {
> task_active_pid_ns(current)->reboot_cmd = cmd;
> sigkill_my_init();
> }
Hi Oleg,
what would be your advice to get rid of from_ancestor_ns which prevent
the signal to be delivered to the init process ?
Thanks
-- Daniel
next prev parent reply other threads:[~2011-08-18 23:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 20:23 [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Daniel Lezcano
2011-08-11 20:24 ` [PATCH 1/2] add SA_CLDREBOOT flag Daniel Lezcano
2011-08-14 16:15 ` Oleg Nesterov
2011-08-14 16:36 ` Bruno Prémont
2011-08-14 17:10 ` Oleg Nesterov
2011-08-11 20:24 ` [PATCH 2/2] Notify container-init parent a 'reboot' occured Daniel Lezcano
2011-08-11 21:09 ` Serge Hallyn
2011-08-11 21:30 ` Daniel Lezcano
2011-08-11 21:50 ` Serge Hallyn
2011-08-12 16:29 ` Serge Hallyn
2011-08-12 20:42 ` Daniel Lezcano
2011-08-12 21:13 ` Serge Hallyn
2011-08-13 0:19 ` Matt Helsley
2011-08-13 14:41 ` Daniel Lezcano
2011-08-14 16:01 ` Oleg Nesterov
2011-08-14 16:17 ` [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot Oleg Nesterov
2011-08-14 21:36 ` Serge E. Hallyn
2011-08-15 14:47 ` Oleg Nesterov
2011-08-15 17:39 ` Serge E. Hallyn
2011-08-15 17:50 ` Daniel Lezcano
2011-08-18 23:46 ` Daniel Lezcano [this message]
2011-08-19 15:24 ` Oleg Nesterov
2011-08-22 12:28 ` Daniel Lezcano
2011-08-22 15:44 ` Oleg Nesterov
2011-08-22 16:31 ` Bruno Prémont
2011-08-22 17:39 ` Oleg Nesterov
2011-08-22 19:17 ` Bruno Prémont
2011-08-23 13:33 ` Oleg Nesterov
2011-08-23 14:09 ` Greg Kurz
2011-08-23 14:29 ` Oleg Nesterov
2011-08-24 19:44 ` Bruno Prémont
2011-08-25 15:37 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4DA461.8030006@free.fr \
--to=daniel.lezcano@free.fr \
--cc=akpm@linux-foundation.org \
--cc=bonbons@linux-vserver.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox