public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: LKML <linux-kernel@vger.kernel.org>, gerg@uclinux.org
Subject: m68k with mmu doesn't compile after 66d857b08b8c3ed
Date: Sat, 20 Aug 2011 14:18:57 -0500	[thread overview]
Message-ID: <4E5008A1.8070105@landley.net> (raw)

The m68k build in 3.0 dies with this:

  CC      arch/m68k/kernel/dma.o
In file included from arch/m68k/kernel/dma.c:4:
arch/m68k/kernel/dma_no.c: In function 'dma_sync_single_for_cpu':
arch/m68k/kernel/dma_no.c:44: error: implicit declaration of function
'flush_dcache_range'
make[1]: *** [arch/m68k/kernel/dma.o] Error 1
make: *** [arch/m68k/kernel] Error 2

That file includes <asm/cacheflush.h>, which for m68k is:

#ifdef __uClinux__
#include "cacheflush_no.h"
#else
#include "cacheflush_mm.h"
#endif

The nommu header (cacheflush_no.h) does #define flush_dcache_range(),
but the clacheflush_mm.h version does not.  I.E. you can only currently
build m68k for Coldfire, you can no longer build it for an actual m68k.

(A git log of Linus' tree shows cacheflush_mm.h hasn't been touched
since 2010, and I pulled earlier today.)

Rob

             reply	other threads:[~2011-08-20 19:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20 19:18 Rob Landley [this message]
2011-08-20 19:46 ` m68k with mmu doesn't compile after 66d857b08b8c3ed Geert Uytterhoeven
2011-08-20 22:22   ` Rob Landley
2011-08-22  3:40   ` Greg Ungerer
2011-08-23 11:57     ` Rob Landley
2011-08-20 20:14 ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5008A1.8070105@landley.net \
    --to=rob@landley.net \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox