From: Jens Axboe <jaxboe@fusionio.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] block bits for 3.1-rc
Date: Sun, 21 Aug 2011 19:56:17 +0200 [thread overview]
Message-ID: <4E5146C1.508@fusionio.com> (raw)
In-Reply-To: <20110820174137.GA27243@infradead.org>
On 2011-08-20 19:41, Christoph Hellwig wrote:
> On Fri, Aug 19, 2011 at 03:16:40PM +0200, Jens Axboe wrote:
>> - Revert of the CFQ meta data special treatment patch, it's been shown
>> to regress a kernel build workload by about 10%. More investigation
>> is needed, for 3.1 lets just back it out.
>
> Sorry, but you can't simply do that without any coordination. We have
> added that marker to xfs now that the stupid special casing stopped,
> and turning it back on will cause us massive slowdows. Next time
> please better coordinate this with its users. In fact I have never
> seen this patch or a discussion on any mailinglist.
The discussion was on lkml, as Mike points out. But yes, short time to
react. Since I can't easily cater to both cases right now, how about we
add a temporary second meta flag that is only used for tracing?
REQ_META = (__REQ_META | __REQ_META_TRACE),
RET_META_TRACE = __REQ_META_TRACE,
You get the idea. Not super pretty, but it should solve the immediate
issue.
--
Jens Axboe
next prev parent reply other threads:[~2011-08-21 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 13:16 [GIT PULL] block bits for 3.1-rc Jens Axboe
2011-08-19 17:50 ` Linus Torvalds
2011-08-19 17:57 ` Jens Axboe
2011-08-20 17:41 ` Christoph Hellwig
2011-08-20 19:15 ` Mike Snitzer
2011-08-21 17:56 ` Jens Axboe [this message]
2011-08-21 18:19 ` Christoph Hellwig
2011-08-21 18:37 ` Jens Axboe
2011-08-22 16:52 ` [PATCH 1/2] block: remove READ_META and WRITE_META Christoph Hellwig
2011-08-22 16:52 ` [PATCH 2/2] block: separate priority boosting from REQ_META Christoph Hellwig
2011-08-23 2:05 ` Namhyung Kim
2011-08-23 10:09 ` [PATCH 2/2 v2] " Christoph Hellwig
2011-08-23 12:31 ` Namhyung Kim
2011-08-23 12:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5146C1.508@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox