From: Ryan Mallon <rmallon@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] backlight: ep93xx_bl: add missing include of linux/module.h
Date: Mon, 22 Aug 2011 09:39:48 +1000 [thread overview]
Message-ID: <4E519744.1020707@gmail.com> (raw)
In-Reply-To: <1313937209.13671.3.camel@phoenix>
On 22/08/11 00:33, Axel Lin wrote:
> ep93xx_bl.c uses interfaces from linux/module.h,
> so it should include that file. This patch fixes below build errors.
Thanks,
Acked-by: Ryan Mallon <rmallon@gmail.com>
> CC [M] drivers/video/backlight/ep93xx_bl.o
> drivers/video/backlight/ep93xx_bl.c:138: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/video/backlight/ep93xx_bl.c:158: error: expected declaration specifiers or '...' before string constant
> drivers/video/backlight/ep93xx_bl.c:158: warning: data definition has no type or storage class
> drivers/video/backlight/ep93xx_bl.c:158: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/video/backlight/ep93xx_bl.c:158: warning: function declaration isn't a prototype
> drivers/video/backlight/ep93xx_bl.c:159: error: expected declaration specifiers or '...' before string constant
> drivers/video/backlight/ep93xx_bl.c:159: warning: data definition has no type or storage class
> drivers/video/backlight/ep93xx_bl.c:159: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/video/backlight/ep93xx_bl.c:159: warning: function declaration isn't a prototype
> drivers/video/backlight/ep93xx_bl.c:160: error: expected declaration specifiers or '...' before string constant
> drivers/video/backlight/ep93xx_bl.c:160: warning: data definition has no type or storage class
> drivers/video/backlight/ep93xx_bl.c:160: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/video/backlight/ep93xx_bl.c:160: warning: function declaration isn't a prototype
> drivers/video/backlight/ep93xx_bl.c:161: error: expected declaration specifiers or '...' before string constant
> drivers/video/backlight/ep93xx_bl.c:161: warning: data definition has no type or storage class
> drivers/video/backlight/ep93xx_bl.c:161: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS'
> drivers/video/backlight/ep93xx_bl.c:161: warning: function declaration isn't a prototype
> make[3]: *** [drivers/video/backlight/ep93xx_bl.o] Error 1
> make[2]: *** [drivers/video/backlight] Error 2
> make[1]: *** [drivers/video] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index 9f1e389..b058291 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -11,7 +11,7 @@
> * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
> */
>
> -
> +#include<linux/module.h>
> #include<linux/platform_device.h>
> #include<linux/io.h>
> #include<linux/fb.h>
next prev parent reply other threads:[~2011-08-21 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 14:33 [PATCH] backlight: ep93xx_bl: add missing include of linux/module.h Axel Lin
2011-08-21 23:39 ` Ryan Mallon [this message]
2011-08-21 23:55 ` Ryan Mallon
2011-08-22 16:35 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E519744.1020707@gmail.com \
--to=rmallon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox