From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932084Ab1HUXlu (ORCPT ); Sun, 21 Aug 2011 19:41:50 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:33007 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996Ab1HUXlt (ORCPT ); Sun, 21 Aug 2011 19:41:49 -0400 Message-ID: <4E5197B8.8020608@gmail.com> Date: Mon, 22 Aug 2011 09:41:44 +1000 From: Ryan Mallon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: Axel Lin CC: linux-kernel@vger.kernel.org, H Hartley Sweeten , Paul Mundt , linux-fbdev@vger.kernel.org Subject: Re: [PATCH] video: ep93xx-fb: add missing include of linux/module.h References: <1313937545.13671.5.camel@phoenix> In-Reply-To: <1313937545.13671.5.camel@phoenix> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/11 00:39, Axel Lin wrote: > ep93xx-fb.c uses interfaces from linux/module.h, > so it should include that file. This patch fixes below build errors. What actually changed to make these files broken? Did some other header previously include module.h for us? How many other drivers are broken? Anyway, the change is okay. Acked-by: Ryan Mallon > CC drivers/video/ep93xx-fb.o > drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' > drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant > drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function) > drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant > drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class > drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' > drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype > drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant > drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class > drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' > drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype > drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant > drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class > drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype > drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant > drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class > drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype > make[2]: *** [drivers/video/ep93xx-fb.o] Error 1 > make[1]: *** [drivers/video] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Axel Lin > --- > drivers/video/ep93xx-fb.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c > index 40e5f17..8133a9d 100644 > --- a/drivers/video/ep93xx-fb.c > +++ b/drivers/video/ep93xx-fb.c > @@ -17,6 +17,7 @@ > * > */ > > +#include > #include > #include > #include