From: Liam Girdwood <lrg@ti.com>
To: Julia Lawall <julia@diku.dk>
Cc: Dong Aisheng-B29396 <B29396@freescale.com>,
Wolfram Sang <w.sang@pengutronix.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound/soc/mxs/mxs-saif.c: add missing kfree
Date: Mon, 22 Aug 2011 11:21:04 +0100 [thread overview]
Message-ID: <4E522D90.6080805@ti.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1108211318060.4072@ask.diku.dk>
On 21/08/11 12:18, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Move the test on pdev->id before the kzalloc to avoid requiring kfree when
> the test fails. This fix was suggested by Wolfram Sang.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> expression E1!=0,E2,E3,E4;
> statement S;
> iterator I;
> @@
>
> (
> if (...) { ... when != kfree(x)
> when != x = E3
> when != E3 = x
> * return ...;
> }
> ... when != x = E2
> when != I(...,x,...) S
> if (...) { ... when != x = E4
> kfree(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-08-22 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 6:12 [PATCH 3/4] sound/soc/mxs/mxs-saif.c: add missing kfree Julia Lawall
2011-08-20 13:44 ` Wolfram Sang
2011-08-20 15:18 ` Julia Lawall
2011-08-21 10:29 ` Dong Aisheng-B29396
2011-08-21 10:57 ` Julia Lawall
2011-08-21 11:18 ` [PATCH] " Julia Lawall
2011-08-21 11:29 ` Wolfram Sang
2011-08-21 13:40 ` Dong Aisheng-B29396
2011-08-22 10:21 ` Liam Girdwood [this message]
2011-08-22 22:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E522D90.6080805@ti.com \
--to=lrg@ti.com \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox