From: Liam Girdwood <lrg@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: soc-core: use GFP_KERNEL flag for kmalloc in snd_soc_cnew
Date: Mon, 22 Aug 2011 11:59:25 +0100 [thread overview]
Message-ID: <4E52368D.4050301@ti.com> (raw)
In-Reply-To: <1313809425.4691.3.camel@phoenix>
On 20/08/11 04:03, Axel Lin wrote:
> GFP_ATOMIC is not needed here, use GFP_KERNEL instead.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index ae93aa8..b6d8716 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1913,7 +1913,7 @@ struct snd_kcontrol *snd_soc_cnew(const struct snd_kcontrol_new *_template,
>
> if (prefix) {
> name_len = strlen(long_name) + strlen(prefix) + 2;
> - name = kmalloc(name_len, GFP_ATOMIC);
> + name = kmalloc(name_len, GFP_KERNEL);
> if (!name)
> return NULL;
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-08-22 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 3:03 [PATCH] ASoC: soc-core: use GFP_KERNEL flag for kmalloc in snd_soc_cnew Axel Lin
2011-08-22 10:59 ` Liam Girdwood [this message]
2011-08-22 22:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52368D.4050301@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox