From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754431Ab1HVXoD (ORCPT ); Mon, 22 Aug 2011 19:44:03 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:43074 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589Ab1HVXoB (ORCPT ); Mon, 22 Aug 2011 19:44:01 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.4.0 Message-ID: <4E52E986.8030405@jp.fujitsu.com> Date: Tue, 23 Aug 2011 08:43:02 +0900 From: Tsutomu Itoh User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.20) Gecko/20110804 Thunderbird/3.1.12 MIME-Version: 1.0 To: Wanlong Gao CC: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, chris.mason@oracle.com Subject: Re: [PATCH] btrfs:make btrfs_init_compress() return void References: <1314022940-6717-1-git-send-email-wanlong.gao@gmail.com> In-Reply-To: <1314022940-6717-1-git-send-email-wanlong.gao@gmail.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2011/08/22 23:22), Wanlong Gao wrote: > From: Wanlong Gao > > Make btrfs_init_compress() return void, since it always return 0, > and no need to check return value. > > Signed-off-by: Wanlong Gao > --- > fs/btrfs/compression.c | 3 +-- > fs/btrfs/compression.h | 2 +- > fs/btrfs/super.c | 7 ++----- > 3 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index 8ec5d86..b2dbefa 100644 > --- a/fs/btrfs/compression.c > +++ b/fs/btrfs/compression.c > @@ -731,7 +731,7 @@ struct btrfs_compress_op *btrfs_compress_op[] = { > &btrfs_lzo_compress, > }; > > -int __init btrfs_init_compress(void) > +void __init btrfs_init_compress(void) > { > int i; > > @@ -741,7 +741,6 @@ int __init btrfs_init_compress(void) > atomic_set(&comp_alloc_workspace[i], 0); > init_waitqueue_head(&comp_workspace_wait[i]); > } > - return 0; > } > > /* > diff --git a/fs/btrfs/compression.h b/fs/btrfs/compression.h > index a12059f..9afb0a6 100644 > --- a/fs/btrfs/compression.h > +++ b/fs/btrfs/compression.h > @@ -19,7 +19,7 @@ > #ifndef __BTRFS_COMPRESSION_ > #define __BTRFS_COMPRESSION_ > > -int btrfs_init_compress(void); > +void btrfs_init_compress(void); > void btrfs_exit_compress(void); > > int btrfs_compress_pages(int type, struct address_space *mapping, > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index 15634d4..31e9654 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -1238,9 +1238,7 @@ static int __init init_btrfs_fs(void) > if (err) > return err; > > - err = btrfs_init_compress(); > - if (err) > - goto free_sysfs; > + btrfs_init_compress(); > > err = btrfs_init_cachep(); > if (err) > @@ -1281,8 +1279,7 @@ free_cachep: > btrfs_destroy_cachep(); > free_compress: > btrfs_exit_compress(); > -free_sysfs: > - btrfs_exit_sysfs(); > + Why remove btrfs_exit_sysfs()? -Tsutomu > return err; > } >