From: Huang Ying <ying.huang@intel.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Pavel Ivanov <paivanof@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: APEI: Can not request iomem region for GARs
Date: Tue, 23 Aug 2011 08:32:16 +0800 [thread overview]
Message-ID: <4E52F510.20700@intel.com> (raw)
In-Reply-To: <CAE9FiQVNGpA9rE0Q7Lx2AB_+8dPEg=f98vqPx1PARkABLVYXqw@mail.gmail.com>
On 08/23/2011 05:04 AM, Yinghai Lu wrote:
> On Mon, Aug 22, 2011 at 9:45 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Mon, Aug 22, 2011 at 1:12 AM, Huang Ying <ying.huang@intel.com> wrote:
>>> Do you have time to try the patch attached with the mail?
>>> acpi_nvs.patch should go first.
>>
>> In this case, we have an ACPI NVS region, and the APEI code is
>> essentially a driver for some registers that reside there. APEI is
>> the entity that manages those registers, and it needs to enforce
>> mutual exclusion so nobody else touches them behind its back, so I
>> think it makes sense for it to request the register regions and mark
>> them busy.
>>
>> My proposal is to change e820 so it either leaves ACPI NVS out of the
>> iomem_resource tree or puts it in but leaves it non-busy.
>
> assume Huang Ying only tested with UEFI native boot?
No. I tested it with legacy BIOS. But ACPI NVS is not used by APEI on
my testing machine.
> i have one local patch for legacy mode booting, and it's similar to
> what Bjorn suggested.
>
> Please check the attached patch.
I think we need help from ACPI guys on why ACPI NVS is marked as busy.
If my understanding were correct, ACPI NVS should not be used by OS at
all, so it is marked as busy. But for APEI, Linux interprets some code
(instructions in ERST/EINJ table) from firmware. I think this is
similar with AML code accessing ACPI NVS.
Hi, Len,
Do you think my understanding is correct?
Best Regards,
Huang Ying
next prev parent reply other threads:[~2011-08-23 0:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 3:43 APEI: Can not request iomem region for GARs Pavel Ivanov
2011-08-19 21:48 ` Bjorn Helgaas
2011-08-22 5:43 ` Huang Ying
2011-08-22 7:12 ` Huang Ying
2011-08-22 16:45 ` Bjorn Helgaas
2011-08-22 21:04 ` Yinghai Lu
2011-08-23 0:32 ` Huang Ying [this message]
2011-08-25 2:45 ` Pavel Ivanov
2011-08-26 4:13 ` Huang Ying
2011-08-26 13:43 ` Bjorn Helgaas
2011-08-29 1:27 ` Huang Ying
2011-08-29 14:48 ` Bjorn Helgaas
2011-08-30 0:57 ` Huang Ying
2011-08-27 3:28 ` Pavel Ivanov
2011-08-29 1:15 ` Huang Ying
2011-08-29 4:10 ` Pavel Ivanov
2011-08-29 5:22 ` Huang Ying
2011-08-29 14:43 ` Pavel Ivanov
2011-08-30 0:55 ` Huang Ying
2011-08-29 5:37 ` Huang Ying
2011-09-03 2:44 ` Pavel Ivanov
2011-09-05 2:05 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52F510.20700@intel.com \
--to=ying.huang@intel.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paivanof@gmail.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox