From: "Jiandong Zheng" <jdzheng@broadcom.com>
To: "Maxin B. John" <maxin.john@gmail.com>
Cc: "Scott Branden" <sbranden@broadcom.com>,
"Russell King" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm: mach-bcmring: fix build error in core.c
Date: Tue, 23 Aug 2011 09:41:51 -0700 [thread overview]
Message-ID: <4E53D84F.5060604@broadcom.com> (raw)
In-Reply-To: <20110823111824.GA2806@maxin>
On 8/23/2011 4:18 AM, Maxin B. John wrote:
> CC arch/arm/mach-bcmring/core.o
> arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
> arch/arm/mach-bcmring/core.c:238: error: implicit declaration of
> function 'sp804_clockevents_register'
> make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
> make: *** [arch/arm/mach-bcmring] Error 2
>
> Please let me know your comments on this fix:
>
> Signed-off-by: Maxin B. John<maxin.john@gmail.com>
> ---
> diff --git a/arch/arm/mach-bcmring/core.c b/arch/arm/mach-bcmring/core.c
> index 43eadbc..430da12 100644
> --- a/arch/arm/mach-bcmring/core.c
> +++ b/arch/arm/mach-bcmring/core.c
> @@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
> */
> bcmring_clocksource_init();
>
> - sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
> + sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
> }
>
> struct sys_timer bcmring_timer = {
>
Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
The same changes was in my comments on May 17 to Russell's serial
patches to convert to sp804 clk dev, but seems it got lost.
next prev parent reply other threads:[~2011-08-23 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 11:18 [PATCH 1/2] arm: mach-bcmring: fix build error in core.c Maxin B. John
2011-08-23 16:41 ` Jiandong Zheng [this message]
2011-08-23 16:45 ` Russell King - ARM Linux
2011-08-23 16:59 ` Jiandong Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E53D84F.5060604@broadcom.com \
--to=jdzheng@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maxin.john@gmail.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox