public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: ctxfi: Bump playback substreams to 256
@ 2011-08-23 22:48 Maarten Lankhorst
  2011-08-24  8:40 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Maarten Lankhorst @ 2011-08-23 22:48 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Linux Kernel Mailing List

There are references in the code to 256 sources, so I tested it with 256 aplays,
of which the first and last with real data and the rest playing /dev/zero .

Also increase amount of page tables, so the default aplay size works.

Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>

---
diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c
index 457d211..2c86226 100644
--- a/sound/pci/ctxfi/ctpcm.c
+++ b/sound/pci/ctxfi/ctpcm.c
@@ -404,7 +404,7 @@ int ct_alsa_pcm_create(struct ct_atc *atc,
 	int err;
 	int playback_count, capture_count;
 
-	playback_count = (IEC958 == device) ? 1 : 8;
+	playback_count = (IEC958 == device) ? 1 : 256;
 	capture_count = (FRONT == device) ? 1 : 0;
 	err = snd_pcm_new(atc->card, "ctxfi", device,
 			  playback_count, capture_count, &pcm);
diff --git a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
index c749fa7..e134b3a 100644
--- a/sound/pci/ctxfi/ctsrc.c
+++ b/sound/pci/ctxfi/ctsrc.c
@@ -20,7 +20,7 @@
 #include "cthardware.h"
 #include <linux/slab.h>
 
-#define SRC_RESOURCE_NUM	64
+#define SRC_RESOURCE_NUM	256
 #define SRCIMP_RESOURCE_NUM	256
 
 static unsigned int conj_mask;
diff --git a/sound/pci/ctxfi/ctvmem.h b/sound/pci/ctxfi/ctvmem.h
index b23adfc..e6da60e 100644
--- a/sound/pci/ctxfi/ctvmem.h
+++ b/sound/pci/ctxfi/ctvmem.h
@@ -18,7 +18,7 @@
 #ifndef CTVMEM_H
 #define CTVMEM_H
 
-#define CT_PTP_NUM	1	/* num of device page table pages */
+#define CT_PTP_NUM	4	/* num of device page table pages */
 
 #include <linux/mutex.h>
 #include <linux/list.h>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: ctxfi: Bump playback substreams to 256
  2011-08-23 22:48 [PATCH] ALSA: ctxfi: Bump playback substreams to 256 Maarten Lankhorst
@ 2011-08-24  8:40 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-08-24  8:40 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: alsa-devel, Linux Kernel Mailing List

At Wed, 24 Aug 2011 00:48:59 +0200,
Maarten Lankhorst wrote:
> 
> There are references in the code to 256 sources, so I tested it with 256 aplays,
> of which the first and last with real data and the rest playing /dev/zero .
> 
> Also increase amount of page tables, so the default aplay size works.
> 
> Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>

Applied now.  Thanks.


Takashi

> ---
> diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c
> index 457d211..2c86226 100644
> --- a/sound/pci/ctxfi/ctpcm.c
> +++ b/sound/pci/ctxfi/ctpcm.c
> @@ -404,7 +404,7 @@ int ct_alsa_pcm_create(struct ct_atc *atc,
>  	int err;
>  	int playback_count, capture_count;
>  
> -	playback_count = (IEC958 == device) ? 1 : 8;
> +	playback_count = (IEC958 == device) ? 1 : 256;
>  	capture_count = (FRONT == device) ? 1 : 0;
>  	err = snd_pcm_new(atc->card, "ctxfi", device,
>  			  playback_count, capture_count, &pcm);
> diff --git a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
> index c749fa7..e134b3a 100644
> --- a/sound/pci/ctxfi/ctsrc.c
> +++ b/sound/pci/ctxfi/ctsrc.c
> @@ -20,7 +20,7 @@
>  #include "cthardware.h"
>  #include <linux/slab.h>
>  
> -#define SRC_RESOURCE_NUM	64
> +#define SRC_RESOURCE_NUM	256
>  #define SRCIMP_RESOURCE_NUM	256
>  
>  static unsigned int conj_mask;
> diff --git a/sound/pci/ctxfi/ctvmem.h b/sound/pci/ctxfi/ctvmem.h
> index b23adfc..e6da60e 100644
> --- a/sound/pci/ctxfi/ctvmem.h
> +++ b/sound/pci/ctxfi/ctvmem.h
> @@ -18,7 +18,7 @@
>  #ifndef CTVMEM_H
>  #define CTVMEM_H
>  
> -#define CT_PTP_NUM	1	/* num of device page table pages */
> +#define CT_PTP_NUM	4	/* num of device page table pages */
>  
>  #include <linux/mutex.h>
>  #include <linux/list.h>
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-24  8:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-23 22:48 [PATCH] ALSA: ctxfi: Bump playback substreams to 256 Maarten Lankhorst
2011-08-24  8:40 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox