From: Jens Axboe <jaxboe@fusionio.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/2]block: change force plug flush call order
Date: Wed, 24 Aug 2011 15:59:06 +0200 [thread overview]
Message-ID: <4E5503AA.3010908@fusionio.com> (raw)
In-Reply-To: <1314176129.29510.34.camel@sli10-conroe>
On 2011-08-24 10:55, Shaohua Li wrote:
> Do blk_flush_plug_list() first and then add new request at the tail. New
> request can't be merged to existing requests, but later new requests might
> be merged with this new one. If blk_flush_plug_list() is done later, the
> merge doesn't happen.
> Believe it or not, this fixes a 10% regression running sysbench workload.
Heh, funky. But conceptually it makes sense to flush first, since we
already know that this request isn't mergeable already. Applied.
--
Jens Axboe
prev parent reply other threads:[~2011-08-24 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 8:55 [patch 1/2]block: change force plug flush call order Shaohua Li
2011-08-24 13:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5503AA.3010908@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox