public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/2]block: simplify force plug flush code a little bit
Date: Wed, 24 Aug 2011 15:59:28 +0200	[thread overview]
Message-ID: <4E5503C0.2030005@fusionio.com> (raw)
In-Reply-To: <1314176130.29510.35.camel@sli10-conroe>

On 2011-08-24 10:55, Shaohua Li wrote:
> Cleaning up the code a little bit. attempt_plug_merge() traverses the plug
> list anyway, we can do the request counting there, so stack size is reduced
> a little bit.
> The motivation here is I suspect if we should count the requests for each
> queue (task could handle multiple disks in the meantime), but my test doesn't
> show it's worthy doing. If somebody proves we should do it, below change
> will make that more easier.

Good change, applied.

-- 
Jens Axboe


      reply	other threads:[~2011-08-24 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24  8:55 [patch 2/2]block: simplify force plug flush code a little bit Shaohua Li
2011-08-24 13:59 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5503C0.2030005@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox