From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042Ab1HXVs6 (ORCPT ); Wed, 24 Aug 2011 17:48:58 -0400 Received: from claw.goop.org ([74.207.240.146]:53642 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973Ab1HXVs4 (ORCPT ); Wed, 24 Aug 2011 17:48:56 -0400 Message-ID: <4E5571C6.10704@goop.org> Date: Wed, 24 Aug 2011 14:48:54 -0700 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Andi Kleen CC: Linus Torvalds , "H. Peter Anvin" , Peter Zijlstra , Ingo Molnar , the arch/x86 maintainers , Linux Kernel Mailing List , Nick Piggin , Jeremy Fitzhardinge Subject: Re: [PATCH 06/18] x86/ticketlock: make __ticket_spin_trylock common References: <20110824214334.GS25996@one.firstfloor.org> In-Reply-To: <20110824214334.GS25996@one.firstfloor.org> X-Enigmail-Version: 1.3.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2011 02:43 PM, Andi Kleen wrote: > On Wed, Aug 24, 2011 at 02:38:12PM -0700, Linus Torvalds wrote: >> On Wed, Aug 24, 2011 at 1:00 PM, Andi Kleen wrote: >>> Can't we just get rid of the small ticket size code path? >>> >>> I couldn't benchmark any difference between the two last time >>> I tried. >> The small locks aren't any faster. They are just smaller. > Are you sure? > > AFAIK it's always > > typedef struct arch_spinlock { > unsigned int slock; > } arch_spinlock_t; Hm, I changed that in this series; arch_spinlock can be 16 bits in the <256 case. I wonder if it matters... J