* [PATCH] Revert "mkuboot.sh: Fail if mkimage is missing"
@ 2011-08-25 11:53 Jiri Kosina
2011-08-25 12:46 ` Roland Stigge
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2011-08-25 11:53 UTC (permalink / raw)
To: Michal Marek, Roland Stigge; +Cc: linux-kernel
This reverts commit bc91c9f3.
It causes the whole build to fail when mkimage is not found. This doesn't
seem right, as the failure is not fatal for the rest of the build.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
scripts/mkuboot.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/mkuboot.sh b/scripts/mkuboot.sh
index 446739c..2e3d3cd 100755
--- a/scripts/mkuboot.sh
+++ b/scripts/mkuboot.sh
@@ -11,7 +11,7 @@ if [ -z "${MKIMAGE}" ]; then
if [ -z "${MKIMAGE}" ]; then
# Doesn't exist
echo '"mkimage" command not found - U-Boot images will not be built' >&2
- exit 1;
+ exit 0;
fi
fi
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "mkuboot.sh: Fail if mkimage is missing"
2011-08-25 11:53 [PATCH] Revert "mkuboot.sh: Fail if mkimage is missing" Jiri Kosina
@ 2011-08-25 12:46 ` Roland Stigge
2011-08-25 18:19 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Roland Stigge @ 2011-08-25 12:46 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Michal Marek, linux-kernel
Hi,
On 08/25/2011 01:53 PM, Jiri Kosina wrote:
> It causes the whole build to fail when mkimage is not found. This doesn't
> seem right, as the failure is not fatal for the rest of the build.
I disagree. As I understand, mkimage is only used on "make uImage". When
I do this and the tool producing the uImage (i.e. the final target) is
missing or can't produce the target otherwise, I expect an error.
Otherwise, this problem would be silently ignored. That's why I created
the original patch in the first place.
Please tell me if I missed come fact.
Thanks for considering,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "mkuboot.sh: Fail if mkimage is missing"
2011-08-25 12:46 ` Roland Stigge
@ 2011-08-25 18:19 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2011-08-25 18:19 UTC (permalink / raw)
To: Roland Stigge; +Cc: Michal Marek, linux-kernel
On Thu, 25 Aug 2011, Roland Stigge wrote:
> Hi,
>
> On 08/25/2011 01:53 PM, Jiri Kosina wrote:
> > It causes the whole build to fail when mkimage is not found. This doesn't
> > seem right, as the failure is not fatal for the rest of the build.
>
> I disagree. As I understand, mkimage is only used on "make uImage". When
> I do this and the tool producing the uImage (i.e. the final target) is
> missing or can't produce the target otherwise, I expect an error.
> Otherwise, this problem would be silently ignored. That's why I created
> the original patch in the first place.
>
> Please tell me if I missed come fact.
Right you are. Sorry for the noise.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-25 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 11:53 [PATCH] Revert "mkuboot.sh: Fail if mkimage is missing" Jiri Kosina
2011-08-25 12:46 ` Roland Stigge
2011-08-25 18:19 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox