From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130Ab1HYSBV (ORCPT ); Thu, 25 Aug 2011 14:01:21 -0400 Received: from terminus.zytor.com ([198.137.202.10]:50749 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755069Ab1HYSBU (ORCPT ); Thu, 25 Aug 2011 14:01:20 -0400 Message-ID: <4E568DD1.5010501@zytor.com> Date: Thu, 25 Aug 2011 11:00:49 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Tejun Heo CC: Linus Torvalds , Suresh Siddha , Anders Eriksson , Ingo Molnar , Sergei Shtylyov , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mtrr: fix UP breakage caused during switch to stop_machine References: <20110825070335.3095B3BC183@tippex.mynet.homeunix.org> <20110825164649.GL2803@mtj.dyndns.org> <1314294182.16133.19.camel@sbsiddha-desk.sc.intel.com> <20110825174656.GN2803@mtj.dyndns.org> In-Reply-To: <20110825174656.GN2803@mtj.dyndns.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2011 10:46 AM, Tejun Heo wrote: > While removing custom rendezvous code and switching to stop_machine, > commit 192d8857427d "x86, mtrr: use stop_machine APIs for doing MTRR > rendezvous" completely dropped mtrr setting code on !CONFIG_SMP > breaking MTRR settting on UP. Fix it by removing the incorrect > CONFIG_SMP. > > Signed-off-by: Tejun Heo > Reported-by: Anders Eriksson > Acked-by: Suresh Siddha > Cc: Linus Torvalds Acked-by: H. Peter Anvin Linus, are you picking this up from email or should I put it in x86/urgent? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.