public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhao Jin <cronozhj@gmail.com>
To: cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
	trivial@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: trivial: cleanup: remove unneeded return
Date: Fri, 26 Aug 2011 14:38:32 +0800	[thread overview]
Message-ID: <4E573F68.1020603@gmail.com> (raw)
In-Reply-To: <CADqbE97+FKz-7op-nmdOVmq3mrXadaxQrtk9Zud90E7iMMEUVQ@mail.gmail.com>

Terribly sorry. It was gmail who wrapped the line.
Please see this following version. Thanks!

---
  mm/slab.c |    5 ++---
  1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 6d90a09..82e0a0e 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3678,13 +3678,12 @@ static inline void __cache_free(struct 
kmem_cache *cachep, void *objp,

      if (likely(ac->avail < ac->limit)) {
          STATS_INC_FREEHIT(cachep);
-        ac->entry[ac->avail++] = objp;
-        return;
      } else {
          STATS_INC_FREEMISS(cachep);
          cache_flusharray(cachep, ac);
-        ac->entry[ac->avail++] = objp;
      }
+
+    ac->entry[ac->avail++] = objp;
  }

  /**
-- 
1.7.4.1


  reply	other threads:[~2011-08-26  6:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26  3:56 [PATCH] slab: trivial: cleanup: remove unneeded return Zhao Jin
2011-08-26  6:30 ` Zhao Jin
2011-08-26  6:38   ` Zhao Jin [this message]
2011-08-26  7:39     ` Yong Zhang
2011-08-26 14:02       ` Zhao Jin
2011-08-26  9:13     ` David Rientjes
2011-08-26 14:09       ` Zhao Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E573F68.1020603@gmail.com \
    --to=cronozhj@gmail.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox