From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754779Ab1HZJ7V (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Aug 2011 05:59:21 -0400
Received: from mailhub.sw.ru ([195.214.232.25]:31851 "EHLO relay.sw.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752803Ab1HZJ7U (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Aug 2011 05:59:20 -0400
Message-ID: <4E576E6F.1030909@openvz.org>
Date: Fri, 26 Aug 2011 13:59:11 +0400
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.19) Gecko/20110702 Iceape/2.0.14
MIME-Version: 1.0
To: David Rientjes <rientjes@google.com>
CC: Michal Hocko <mhocko@suse.cz>, Oleg Nesterov <oleg@redhat.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] oom: skip frozen tasks
References: <20110823073101.6426.77745.stgit@zurg> <alpine.DEB.2.00.1108231313520.21637@chino.kir.corp.google.com> <20110824101927.GB3505@tiehlicka.suse.cz> <alpine.DEB.2.00.1108241226550.31357@chino.kir.corp.google.com> <20110825091920.GA22564@tiehlicka.suse.cz> <20110825151818.GA4003@redhat.com> <20110825164758.GB22564@tiehlicka.suse.cz> <alpine.DEB.2.00.1108251404130.18747@chino.kir.corp.google.com> <4E574CA5.4010701@openvz.org> <alpine.DEB.2.00.1108260209050.14732@chino.kir.corp.google.com>
In-Reply-To: <alpine.DEB.2.00.1108260209050.14732@chino.kir.corp.google.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

David Rientjes wrote:
> On Fri, 26 Aug 2011, Konstantin Khlebnikov wrote:
>
>>> A much better solution would be to lower the badness score that the oom
>>> killer uses for PF_FROZEN threads so that they aren't considered a
>>> priority for kill unless there's nothing else left to kill.
>>
>> Anyway, oom killer shouldn't loop endlessly if it see TIF_MEMDIE on frozen
>> task,
>> it must go on and try to kill somebody else. We cannot wait for thawing this
>> task.
>>
>
> Did you read my suggestion?  I quoted it above again for you.  The badness
> heuristic would only select those tasks to kill as a last resort in the
> hopes they will eventually be thawed and may exit.  Panicking the entire
> machine for what could be isolated by a cgroup is insanity.

Maybe just fix this "panic" logic? OOM killer should panic only on global memory shortage.