public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Nebojsa Trpkovic <trx.lists@gmail.com>,
	linux-kernel@vger.kernel.org,
	Konrad Wilk <konrad.wilk@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: cleancache can lead to serious performance degradation
Date: Fri, 26 Aug 2011 08:24:47 -0500	[thread overview]
Message-ID: <4E579E9F.9090906@linux.vnet.ibm.com> (raw)
In-Reply-To: <3aef71a8-d390-4a91-bfef-561c89edc040@default>

On 08/25/2011 11:56 AM, Dan Magenheimer wrote:

> Third, zcache is relatively new and can certainly benefit from
> the input of other developers.  The lzo1x compression in the kernel
> is fairly slow; Seth Jennings (cc'ed) is looking into alternate
> compression technologies.  Perhaps there is a better compression
> choice more suitable for older-slower processors, probably with a
> poorer compression ratio.  Further, zcache currently does compression
> and decompression with interrupts disabled, which may be a
> significant factor in the slowdowns you've observed.  This should
> be fixable.

This was something I've meaning to ask about.  Why are compression
and decompression done with interrupts disabled?  What would need
to change so that we don't have to disable interrupts?

<cut>
>>> I guess that possible workaround could be to implement some kind of
>>> compression throttling valve for cleancache/zcache:
>>>
>>> - if there's available CPU time (idle cycles or so), then compress
>>> (maybe even with low CPU scheduler priority);
> 
> Agreed, and this low-priority kernel thread ideally would also
> solve the "compress while irqs disabled" problem!

--
Seth

  reply	other threads:[~2011-08-26 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 21:57 cleancache can lead to serious performance degradation Nebojsa Trpkovic
2011-08-25  4:12 ` Konrad Rzeszutek Wilk
2011-08-25 16:56   ` Dan Magenheimer
2011-08-26 13:24     ` Seth Jennings [this message]
2011-08-26 14:42       ` Dan Magenheimer
2011-08-29  0:45     ` Nebojsa Trpkovic
2011-08-29 15:08       ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E579E9F.9090906@linux.vnet.ibm.com \
    --to=sjenning@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=trx.lists@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox