From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779Ab1H2Uo3 (ORCPT ); Mon, 29 Aug 2011 16:44:29 -0400 Received: from usmamail.tilera.com ([206.83.70.75]:29248 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718Ab1H2Uo2 (ORCPT ); Mon, 29 Aug 2011 16:44:28 -0400 Message-ID: <4E5BFA2A.5020900@tilera.com> Date: Mon, 29 Aug 2011 16:44:26 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Matt Fleming CC: Oleg Nesterov , , Arnd Bergmann Subject: Re: [PATCH v2 32/43] tile: Use set_current_blocked() and block_sigmask() References: <1313772419-21951-1-git-send-email-matt@console-pimps.org> <1313772419-21951-33-git-send-email-matt@console-pimps.org> In-Reply-To: <1313772419-21951-33-git-send-email-matt@console-pimps.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/2011 12:46 PM, Matt Fleming wrote: > From: Matt Fleming > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, use the new helper function block_sigmask() which centralises > the code for updating current->blocked after successfully delivering a > signal and reduces the amount of duplicate code across > architectures. In the past some architectures got this code wrong, so > using this helper function should stop that from happening again. > > Cc: Oleg Nesterov > Cc: Arnd Bergmann > Cc: Chris Metcalf > Signed-off-by: Matt Fleming > --- > > v2 of this patch depends on "[PATCH 01/43] signal: Add block_sigmask() > for adding sigmask to current->blocked" so they need to go through the > same tree but this patch would benefit from some maintainer ACK's. > > Chris, I dropped your Acked-by because I felt this patch changed quite > dramatically since v1 and warrants another review. I hope that's OK. > > > arch/tile/kernel/compat_signal.c | 5 +---- > arch/tile/kernel/signal.c | 13 ++----------- > 2 files changed, 3 insertions(+), 15 deletions(-) > Still looks good to me :-) Acked-by: Chris Metcalf Sorry for the late reply; I was away on vacation. -- Chris Metcalf, Tilera Corp. http://www.tilera.com