public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Inki Dae <inki.dae@samsung.com>,
	sw0312.kim@samsung.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.
Date: Wed, 31 Aug 2011 11:28:28 +0900	[thread overview]
Message-ID: <4E5D9C4C.1090808@samsung.com> (raw)
In-Reply-To: <CAF6AEGu3ss-rJC28H1rm2GWLm1bAZnHLftXfMLJQNeqjBt3umQ@mail.gmail.com>

>> +static void samsung_drm_connector_destroy(struct drm_connector *connector)
>> +{
>> +       struct samsung_drm_connector *samsung_connector =
>> +               to_samsung_connector(connector);
>> +
>> +       DRM_DEBUG_KMS("%s\n", __FILE__);
>> +
>> +       drm_sysfs_connector_remove(connector);
>> +       drm_connector_cleanup(connector);
>> +       connector->dev->mode_config.num_connector--;
>
> I wonder if num_connector-- should be in drm_connector_cleanup()..
>

Right, num_connector and num_encoder of mode_config should be decreased
in the cleanup functions, but currently drm driver is missing it.

I sent the patch.

Thanks.

  parent reply	other threads:[~2011-08-31  2:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 11:47 [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210 Inki Dae
2011-08-31  1:57 ` Rob Clark
2011-08-31  2:06   ` Konrad Rzeszutek Wilk
2011-08-31  7:33     ` Inki Dae
2011-08-31  2:28   ` Joonyoung Shim [this message]
2011-08-31  6:51   ` Inki Dae
2011-08-31 16:02     ` Rob Clark
2011-09-01 13:06       ` Inki Dae
2011-09-02  1:02         ` Kyungmin Park
2011-09-02  1:08           ` Rob Clark
2011-09-02  1:18         ` Rob Clark
2011-09-02 12:00           ` Inki Dae
2011-08-31  8:38 ` Thomas Hellstrom
2011-09-01  3:57   ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5D9C4C.1090808@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox