RE: [PATCH v6 05/10] crc32-misc-cleanup.diff

Bob Pearson
2011-09-06T20:18:44Z

>
> Yup. lib-crc-add-slice-by-8-algorithm-to-crc32c.patch is dead meat. I
> sometimes keep things like that around to get them a bit of testing
> while reminding myself that there's an open issue to track.

I thought I was getting close until recently someone sent out a patch set
for crc32c.c, the other 32 bit CRC in common use, based on an earlier
version of the changes we have been working on for crc32.c. This has brought
in other interested parties and created a bit of duplicated code. I am at a
loss as to the best way to proceed. Personally I would like to see this
change go upstream and then let the rest of the world figure out how to best
merge things.

The list of needed changes based on recent comments I am aware of are:
- put back in a couple of header files per Andrew
- fix the summary phrases to conform to coding standards per Andrew
- add signed off by for Joakim to patch 04/10 per Joakim
- fix bug in patch 06/10 noted in my email by passing bits as a parameter
to crc32_body

If anyone wants additional changes please let me know and I can put out a
clean version.