RE: [PATCH v6 05/10] crc32-misc-cleanup.diff

Joakim Tjernlund
2011-09-07T17:05:58Z

"Bob Pearson" <rpearson@systemfabricworks.com> wrote on 2011/09/06 22:18:35:
>
> >
> > Yup. lib-crc-add-slice-by-8-algorithm-to-crc32c.patch is dead meat. I
> > sometimes keep things like that around to get them a bit of testing
> > while reminding myself that there's an open issue to track.
>
> I thought I was getting close until recently someone sent out a patch set
> for crc32c.c, the other 32 bit CRC in common use, based on an earlier
> version of the changes we have been working on for crc32.c. This has brought
> in other interested parties and created a bit of duplicated code. I am at a
> loss as to the best way to proceed. Personally I would like to see this
> change go upstream and then let the rest of the world figure out how to best
> merge things.

The crc32c code should be moved to lib and integrated into crc32.c. Then you get
all the optimizations for free. It think the new crypto crc32c code should just
be nacked.

Jocke