From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086Ab1IAI7S (ORCPT ); Thu, 1 Sep 2011 04:59:18 -0400 Received: from ppsw-50.csi.cam.ac.uk ([131.111.8.150]:53435 "EHLO ppsw-50.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756469Ab1IAI7O (ORCPT ); Thu, 1 Sep 2011 04:59:14 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4E5F4B4E.5060801@cam.ac.uk> Date: Thu, 01 Sep 2011 10:07:26 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110801 Thunderbird/5.0 MIME-Version: 1.0 To: Stephen Warren CC: Greg Kroah-Hartman , Russell King , Andrew Chew , Arnd Bergmann , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 1/3] staging:iio:magnetometer:ak8975 Don't use irq_to_gpio() References: <1314819657-828-1-git-send-email-swarren@nvidia.com> In-Reply-To: <1314819657-828-1-git-send-email-swarren@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/11 20:40, Stephen Warren wrote: > Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in > tegra_defconfig. This causes a build failure. Solve this with a heavy-handed > method for now. > > I suspect the long-term solution is to pass both the IRQ and GPIO IDs > to the driver; the GPIO ID coming from either platform data, or perhaps > enhancing struct i2c_client to add a gpio field alongside irq. Definitely on the platform data front. We need some means of doing this now hence my patch putting most trivial form of that in. > > Signed-off-by: Stephen Warren Acked-by: Jonathan Cameron > --- > Russell, now that irq_to_gpio() is going away, can you comment on how > you'd like to fix drivers that do this kind of thing? Thanks. > > drivers/staging/iio/magnetometer/ak8975.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c > index a17fa9f..bd40e32 100644 > --- a/drivers/staging/iio/magnetometer/ak8975.c > +++ b/drivers/staging/iio/magnetometer/ak8975.c > @@ -477,7 +477,7 @@ static int ak8975_probe(struct i2c_client *client, > int err; > > /* Grab and set up the supplied GPIO. */ > - eoc_gpio = irq_to_gpio(client->irq); > + eoc_gpio = -1; /* FIXME: irq_to_gpio(client->irq) */ > > /* We may not have a GPIO based IRQ to scan, that is fine, we will > poll if so */