From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139Ab1IAJAt (ORCPT ); Thu, 1 Sep 2011 05:00:49 -0400 Received: from ppsw-50.csi.cam.ac.uk ([131.111.8.150]:54391 "EHLO ppsw-50.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107Ab1IAJAq (ORCPT ); Thu, 1 Sep 2011 05:00:46 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4E5F4BAA.9040404@cam.ac.uk> Date: Thu, 01 Sep 2011 10:08:58 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110801 Thunderbird/5.0 MIME-Version: 1.0 To: Stephen Warren CC: Greg Kroah-Hartman , Russell King , Andrew Chew , Arnd Bergmann , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 3/3] staging:iio:magnetometer:ak8975: Fix probe() error-handling References: <1314819657-828-1-git-send-email-swarren@nvidia.com> <1314819657-828-3-git-send-email-swarren@nvidia.com> In-Reply-To: <1314819657-828-3-git-send-email-swarren@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/11 20:40, Stephen Warren wrote: > Fix ak8975_probe() to jump to the appropriate exit labels when an error > occurs. With the previous code, some cleanup actions were being skipped > for some error conditions. > > Signed-off-by: Stephen Warren Acked-by: Jonathan Cameron Thanks for these Stephen. There's one other driver in tree that uses irq_to_gpio (I hadn't registered it was going away till you sent these.) > --- > drivers/staging/iio/magnetometer/ak8975.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c > index 79ed183..d92b3d0 100644 > --- a/drivers/staging/iio/magnetometer/ak8975.c > +++ b/drivers/staging/iio/magnetometer/ak8975.c > @@ -510,7 +510,7 @@ static int ak8975_probe(struct i2c_client *client, > err = ak8975_setup(client); > if (err < 0) { > dev_err(&client->dev, "AK8975 initialization fails\n"); > - goto exit_gpio; > + goto exit_free_iio; > } > > i2c_set_clientdata(client, indio_dev);